Issue/1254 blockquote multilevel text color #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
December 4, 2019 19:24
basic indentation and increase / decrease with tab / shift tab TODO: styling
this stacking of the rects will allow users to customze design however they want, once different level colors are introduced
up to 3 layers, colors are available to be customized
and new nice default color scheme
since quotes affect text color need to be added here to textAttribu recalcuate
for both private and public vars
for mac catalyst and ipad
to reflect its an array
it is written more clear now
and made public so users can change
will be addressed in separate PR
need to alter the depth logic
…54_blockquote_multilevel_textColor
its important to pass the borderColors when initiating the formatter so it can change them correctly
…54_blockquote_multilevel_textColor
|
We recently switched the project license. Aztec is now under the MPL v2.0. More info on this ticket: #1305 If this PR gets merged, the code will be under the MPL v2.0. |
|
Can this be merged and released please? |
|
This grants support for Dark mode which is imperative for block quotes to appear correctly. I would greatly appreciate if this PR could be merged once the test and licensing is resolved. Thank you in advance. |
|
Still waiting... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254
To test:
changes text color when in quotes or nested quotes for more styling options
logic is now inside
BlockquoteFormatterKnown issue:
pasting text doesn't change color, would like assistance here.