Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix/ime iob fix" #882

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Revert "Fix/ime iob fix" #882

merged 2 commits into from
Dec 10, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Dec 5, 2019

Reverts #834

According to what has been observed (no significant contribution to lowering the number of occurrences of the crash observed in wordpress-mobile/WordPress-Android#9904), the patch is being reverted to avoid introducing this unneeded complexity.

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on WordPress-Android by setting aztecVersion=4416b4f041628260bb9aab4e88ce82d20d27cb1a and testing various text input flows in both the Gutenberg editor and Aztec. Everything works as expected. LGTM after conflicts are resolved.

@mzorz
Copy link
Contributor Author

mzorz commented Dec 10, 2019

Checked a few paths after merge conflict resolution, seems to work well and tests passed, merging

@mzorz mzorz merged commit 75c0b6c into develop Dec 10, 2019
@mzorz mzorz deleted the revert-834-fix/ime-iob-fix branch December 10, 2019 17:06
@hypest hypest mentioned this pull request Feb 24, 2020
1 task
@mzorz mzorz mentioned this pull request Aug 25, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants