Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unneeded logging #806

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Remove some unneeded logging #806

merged 2 commits into from
Apr 9, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Apr 9, 2019 •
edited
Loading

Small PR that removes unneeded logging that convolutes the logs being sent to Fabric, sometimes occupying space that some other information would find useful.

fabric-5a76a4fa8cb3c2fa634286c6

@mzorz mzorz requested a review from daniloercoli April 9, 2019 12:01
daniloercoli
daniloercoli approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mzorz mzorz merged commit 7e968c3 into develop Apr 9, 2019
@mzorz mzorz deleted the clean/debug-logging branch April 9, 2019 12:26
@mzorz
Copy link
Contributor Author

mzorz commented Apr 9, 2019

Thank you @daniloercoli! 🙇

@jtreanor jtreanor mentioned this pull request Apr 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli daniloercoli approved these changes

Assignees
No one assigned
Labels
low hanging fruit performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzorz @daniloercoli