Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #516 by by re-setting the Editable after manipulating its spans, as commented in #516 (comment)
This PR proposes the use of a method within
AztecEditor
to make sure theEditable
is reset.It also fixes the case commented in #516 (comment)
Note: as a consequence of this change, I've observed the
onMediaDeleted
method for theDeleteMediaElementWatcher
was called each time a new character/span was inserted right before the Caption, so that was also fixed in f43d5e2.Test
on API 26/27:
CASE A:
CASE B:
Also verify there's no changes in behavior for other API versions.
Review
@0nko