Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mail): implement the send mail view #337

Merged
merged 23 commits into from
Oct 4, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
393d5f0
feat: 메일 발송 페이지 기능 베이스 레이아웃 추가
Rok93 Sep 13, 2021
947ac76
feat: 대략적인 개별, 그룹 발송 기능 틀 구현
Rok93 Sep 15, 2021
cf2f20f
feat: 업로드 기능 제외한 메일 발송 페이지 구현
Rok93 Sep 15, 2021
b528570
feat: 업로드 버튼 추가
Rok93 Sep 16, 2021
c4b8f59
refactor: 메일 첨부파일 업로드 기능의 최대 용량을 10MB로 변경 및 모든 파일 타입을 업로드 허용하도록 변경
Rok93 Sep 20, 2021
8e6b68f
refactor: 첨부파일 업로드 버튼이 메일 본문 아래에 위치하도록 변경
Rok93 Sep 20, 2021
e6322b0
feat: 메일을 보내는 발신자 표시 추가
Rok93 Sep 20, 2021
47231b0
refactor: 개별 발송, 그룹 발송 기능을 하나의 페이지에서 가능하도록 변경
Rok93 Sep 21, 2021
d9f5c93
refactor: 그룹 발송 기능을 Dialog 컴포넌트 클래스로 분리
Rok93 Sep 22, 2021
24f387e
refactor: 개별 발송 기능을 Dialog 컴포넌트 클래스로 분리
Rok93 Sep 22, 2021
355547b
refactor: 개별 발송 Dialog 컴포넌트 클래스의 파라미터 순서 변경
Rok93 Sep 22, 2021
cc54a2d
refactor: 개별 발송 Dialog의 추가 버튼을 적용 버튼으로 변경
Rok93 Sep 22, 2021
c7fc6c4
resolve conflict
Rok93 Sep 23, 2021
cd0c86e
feat: form layout 적용 및 Grid 추가
Rok93 Sep 23, 2021
619dfde
feat: MailTarget Grid 삭제 버튼 추가
Rok93 Sep 23, 2021
e22c80a
feat: MailTarget Grid 삭제 버튼 추가
Rok93 Sep 23, 2021
a5a7bda
refactor: 메일의 각 컴포넌트의 라벨을 텍스트 라벨로 변경
Rok93 Sep 24, 2021
7bbad19
refactor: UI 피드백 반영
Rok93 Sep 25, 2021
7ab7abb
Merge branch 'develop' into feature/send-mail-page
Rok93 Sep 29, 2021
7566eb1
refactor: 마찌 피드백 반영
Rok93 Oct 1, 2021
97a7bd4
refactor(mail): polish the code
woowahan-pjs Oct 4, 2021
32f321b
refactor(support): rename search bar to search box
woowahan-pjs Oct 4, 2021
98597dd
refactor(mail): polish the code
woowahan-pjs Oct 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/kotlin/apply/ui/admin/BaseLayout.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package apply.ui.admin

import apply.ui.admin.cheater.CheatersView
import apply.ui.admin.evaluation.EvaluationsView
import apply.ui.admin.mail.MailSelectionsView
import apply.ui.admin.recruitment.RecruitmentsView
import apply.ui.admin.selections.SelectionsView
import com.vaadin.flow.component.Component
Expand All @@ -25,7 +26,8 @@ class BaseLayout : AppLayout() {
"모집 관리" to RecruitmentsView::class.java,
"평가 관리" to EvaluationsView::class.java,
"선발 과정" to SelectionsView::class.java,
"부정 행위자" to CheatersView::class.java
"부정 행위자" to CheatersView::class.java,
"메일 발송" to MailSelectionsView::class.java
)

init {
Expand Down
79 changes: 79 additions & 0 deletions src/main/kotlin/apply/ui/admin/mail/GroupMailFormView.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
package apply.ui.admin.mail

import apply.application.EvaluationService
import apply.application.MailTargetService
import apply.application.RecruitmentResponse
import apply.application.RecruitmentService
import apply.domain.evaluation.Evaluation
import apply.domain.evaluationtarget.EvaluationStatus
import apply.ui.admin.BaseLayout
import com.vaadin.flow.component.Component
import com.vaadin.flow.component.orderedlayout.HorizontalLayout
import com.vaadin.flow.component.select.Select
import com.vaadin.flow.router.Route
import support.views.Title
import support.views.createItemSelect

@Route(value = "group", layout = BaseLayout::class)
class GroupMailFormView(
private val recruitmentService: RecruitmentService,
private val evaluationService: EvaluationService,
private val mailTargetService: MailTargetService
) : MailFormView(mailTargetService) {
private val recruitment: Select<RecruitmentResponse>
private val evaluation: Select<Evaluation>
private val evaluationStatus: Select<EvaluationStatus>

init {
evaluation = createEvaluationItem()
evaluationStatus = createEvaluationStatusItem(evaluation)
recruitment = createRecruitmentItem(evaluation)
add(Title("그룹 발송"), createMailForm())
setWidthFull()
}

override fun createReceiverFilter(): Component {
return HorizontalLayout(recruitment, evaluation, evaluationStatus)
}

private fun createRecruitmentItem(evaluation: Select<Evaluation>): Select<RecruitmentResponse> {
return createItemSelect<RecruitmentResponse>("모집").apply {
setItems(*recruitmentService.findAll().toTypedArray())
setItemLabelGenerator { it.title }
addValueChangeListener {
evaluation.apply {
setItems(*evaluationService.findAllByRecruitmentId(it.value.id).toTypedArray())
setItemLabelGenerator { it.title }
}
}
}
}

private fun createEvaluationItem(): Select<Evaluation> {
return createItemSelect("평가")
}

private fun createEvaluationStatusItem(evaluation: Select<Evaluation>): Select<EvaluationStatus> {
return createItemSelect<EvaluationStatus>("모집 상태").apply {
setItems(*EvaluationStatus.values())
setItemLabelGenerator { it.toText() }
addValueChangeListener {
receivers.clear()
val mailTargets = mailTargetService.findMailTargets(evaluation.value.id, it.value).map { it.email }
receivers.addAll(
mailTargets
)
println("조회한 mailTargets: $mailTargets")
println("현재 receivers: $receivers")
}
}
}

private fun EvaluationStatus.toText() =
when (this) {
EvaluationStatus.WAITING -> "평가 전"
EvaluationStatus.PASS -> "합격"
EvaluationStatus.FAIL -> "탈락"
EvaluationStatus.PENDING -> "보류"
}
}
121 changes: 121 additions & 0 deletions src/main/kotlin/apply/ui/admin/mail/IndividualMailFormView.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
package apply.ui.admin.mail

import apply.application.ApplicantResponse
import apply.application.ApplicantService
import apply.application.MailTargetService
import apply.ui.admin.BaseLayout
import com.vaadin.flow.component.Component
import com.vaadin.flow.component.button.Button
import com.vaadin.flow.component.dialog.Dialog
import com.vaadin.flow.component.grid.Grid
import com.vaadin.flow.component.html.H2
import com.vaadin.flow.component.orderedlayout.FlexComponent
import com.vaadin.flow.component.orderedlayout.HorizontalLayout
import com.vaadin.flow.component.orderedlayout.VerticalLayout
import com.vaadin.flow.data.renderer.ComponentRenderer
import com.vaadin.flow.data.renderer.Renderer
import com.vaadin.flow.router.Route
import support.views.Title
import support.views.addSortableColumn
import support.views.createErrorButton
import support.views.createNormalButton
import support.views.createPrimaryButton
import support.views.createSearchBar

@Route(value = "personal", layout = BaseLayout::class)
class IndividualMailFormView(
private val applicantService: ApplicantService,
mailTargetService: MailTargetService
) : MailFormView(mailTargetService) {
init {
add(Title("개별 발송"), createMailForm())
setWidthFull()
}

override fun createReceiverFilter(): Component {
return createNormalButton("지원자 조회") {
Dialog().apply {
width = "800px"
height = "90%"
val applicants = HorizontalLayout().apply {
setWidthFull()
}
add(
H2("지원자 정보 검색"),
HorizontalLayout(
createAddReceivers(),
HorizontalLayout(
createErrorButton("취소") {
close()
}
).apply {
justifyContentMode = FlexComponent.JustifyContentMode.END
defaultHorizontalComponentAlignment = FlexComponent.Alignment.END
}
),
applicants
).apply {
setWidthFull()
}
open()
}
}.apply { isEnabled = true }
}

private fun createAddReceivers(): Component {
val container = VerticalLayout()
return VerticalLayout(
createSearchBar {
container.removeAll()
val founds = applicantService.findAllByKeyword(it)
if (founds.isNotEmpty()) {
container.add(
createGrid(founds)
)
}
},
container
)
}

private fun createGrid(applicantResponse: List<ApplicantResponse>): Component {
return Grid<ApplicantResponse>(10).apply {
addSortableColumn("이름", ApplicantResponse::name)
addSortableColumn("이메일", ApplicantResponse::email)
addColumn(createEditAndDeleteButton()).apply { isAutoWidth = true }
setItems(applicantResponse)
}
}

private fun createEditAndDeleteButton(): Renderer<ApplicantResponse> {
return ComponentRenderer<Component, ApplicantResponse> { applicantResponse ->
HorizontalLayout(
createAddOrDeleteButton(applicantResponse)
)
}
}

private fun createAddOrDeleteButton(applicantResponse: ApplicantResponse): Component {
if (this.receivers.contains(applicantResponse.email)) {
return createDeleteButton(applicantResponse)
}

return createAddButton(applicantResponse)
}

private fun createAddButton(applicantResponse: ApplicantResponse): Button {
return createPrimaryButton("추가") {
this.receivers.add(applicantResponse.email)
}.apply {
isDisableOnClick = true
}
}

private fun createDeleteButton(applicantResponse: ApplicantResponse): Button {
return createErrorButton("삭제") {
this.receivers.remove(applicantResponse.email)
}.apply {
isDisableOnClick = true
}
}
}
60 changes: 60 additions & 0 deletions src/main/kotlin/apply/ui/admin/mail/MailFormView.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
package apply.ui.admin.mail

import apply.application.MailTargetService
import com.vaadin.flow.component.Component
import com.vaadin.flow.component.html.H3
import com.vaadin.flow.component.html.H4
import com.vaadin.flow.component.orderedlayout.FlexComponent
import com.vaadin.flow.component.orderedlayout.VerticalLayout
import com.vaadin.flow.component.textfield.TextArea
import com.vaadin.flow.component.textfield.TextField
import com.vaadin.flow.router.RoutePrefix
import support.views.createPrimaryButton

@RoutePrefix(value = "admin/emails")
abstract class MailFormView(
private val mailTargetService: MailTargetService
) : VerticalLayout() {
protected val title: TextField = TextField("메일 제목", "메일 제목 입력")
protected val receivers: MutableList<String> = mutableListOf()
protected val content: TextArea = createMailBody()

protected fun createMailForm(): Component {
val titleText = VerticalLayout(
H3("메일 제목"),
title.apply { setSizeFull() }
)

val receivers = VerticalLayout(H4("수신자"), createReceiverFilter())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수신자 목록이 모집, 평가, 모집상태 하부에 뜨는게 어떨까요?

val mailBody = VerticalLayout(
content
).apply {
setSizeFull()
}

val sendButton = VerticalLayout(
createPrimaryButton("전송") {
println("title: ${title.value} receivers: ${this.receivers} content: ${this.content.value}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹~시 제가 해당 print문을 못찾는 걸까요?ㅠㅠㅠ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어.... 이 부분은 아직 emailService에 지금의 기능에 적합한(?) 메일 전송 기능이 구현되어 있지 않아 비워뒀습니다.
print문만 두면 오해의 여지가 있을 것 같아 현재는 todo로 표시해두었습니다.

혹시 전송 버튼을 눌러도 콘솔 창에 출력이 안된다는 말씀이신가요?? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네네ㅠ콘솔에 안 뜨는것 같아서 남겼는데 제가 못찾는거라면 알려주세요ㅎㅎㅎ

// todo: (print 내용 지우고) mailSender로 메일 보내기!
}
).apply {
setSizeFull()
}

return VerticalLayout(titleText, receivers, mailBody, sendButton).apply {
setSizeFull()
justifyContentMode = FlexComponent.JustifyContentMode.CENTER
defaultHorizontalComponentAlignment = FlexComponent.Alignment.CENTER
}
}

private fun createMailBody(): TextArea {
return TextArea("메일 본문").apply {
setSizeFull()
style.set("minHeight", "800px")
placeholder = "메일 본문 입력"
}
}

abstract fun createReceiverFilter(): Component
}
44 changes: 44 additions & 0 deletions src/main/kotlin/apply/ui/admin/mail/MailSelectionsView.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
package apply.ui.admin.mail

import apply.ui.admin.BaseLayout
import com.vaadin.flow.component.Component
import com.vaadin.flow.component.UI
import com.vaadin.flow.component.orderedlayout.FlexComponent
import com.vaadin.flow.component.orderedlayout.HorizontalLayout
import com.vaadin.flow.component.orderedlayout.VerticalLayout
import com.vaadin.flow.router.Route
import support.views.Title
import support.views.createPrimaryButton

@Route(value = "admin/emails", layout = BaseLayout::class)
class MailSelectionsView : VerticalLayout() {
init {
add(Title("메일 발송"), *createMailTypeButtons())
}

private fun createMailTypeButtons(): Array<Component> {
return arrayOf(createGroupMailButton(), createIndividualMailButton())
}

private fun createGroupMailButton(): Component {
return HorizontalLayout(
createPrimaryButton("그룹 발송") {
UI.getCurrent().navigate(GroupMailFormView::class.java)
}
).apply {
setWidthFull()
justifyContentMode = FlexComponent.JustifyContentMode.CENTER
}
}

private fun createIndividualMailButton(): Component {
return HorizontalLayout(
createPrimaryButton("개별 발송") {
UI.getCurrent().navigate(IndividualMailFormView::class.java)
}
).apply {
setWidthFull()
justifyContentMode = FlexComponent.JustifyContentMode.CENTER
}
}
}