Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mail): implement the send mail view #337

Merged
merged 23 commits into from
Oct 4, 2021
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
393d5f0
feat: 메일 발송 페이지 기능 베이스 레이아웃 추가
Rok93 Sep 13, 2021
947ac76
feat: 대략적인 개별, 그룹 발송 기능 틀 구현
Rok93 Sep 15, 2021
cf2f20f
feat: 업로드 기능 제외한 메일 발송 페이지 구현
Rok93 Sep 15, 2021
b528570
feat: 업로드 버튼 추가
Rok93 Sep 16, 2021
c4b8f59
refactor: 메일 첨부파일 업로드 기능의 최대 용량을 10MB로 변경 및 모든 파일 타입을 업로드 허용하도록 변경
Rok93 Sep 20, 2021
8e6b68f
refactor: 첨부파일 업로드 버튼이 메일 본문 아래에 위치하도록 변경
Rok93 Sep 20, 2021
e6322b0
feat: 메일을 보내는 발신자 표시 추가
Rok93 Sep 20, 2021
47231b0
refactor: 개별 발송, 그룹 발송 기능을 하나의 페이지에서 가능하도록 변경
Rok93 Sep 21, 2021
d9f5c93
refactor: 그룹 발송 기능을 Dialog 컴포넌트 클래스로 분리
Rok93 Sep 22, 2021
24f387e
refactor: 개별 발송 기능을 Dialog 컴포넌트 클래스로 분리
Rok93 Sep 22, 2021
355547b
refactor: 개별 발송 Dialog 컴포넌트 클래스의 파라미터 순서 변경
Rok93 Sep 22, 2021
cc54a2d
refactor: 개별 발송 Dialog의 추가 버튼을 적용 버튼으로 변경
Rok93 Sep 22, 2021
c7fc6c4
resolve conflict
Rok93 Sep 23, 2021
cd0c86e
feat: form layout 적용 및 Grid 추가
Rok93 Sep 23, 2021
619dfde
feat: MailTarget Grid 삭제 버튼 추가
Rok93 Sep 23, 2021
e22c80a
feat: MailTarget Grid 삭제 버튼 추가
Rok93 Sep 23, 2021
a5a7bda
refactor: 메일의 각 컴포넌트의 라벨을 텍스트 라벨로 변경
Rok93 Sep 24, 2021
7bbad19
refactor: UI 피드백 반영
Rok93 Sep 25, 2021
7ab7abb
Merge branch 'develop' into feature/send-mail-page
Rok93 Sep 29, 2021
7566eb1
refactor: 마찌 피드백 반영
Rok93 Oct 1, 2021
97a7bd4
refactor(mail): polish the code
woowahan-pjs Oct 4, 2021
32f321b
refactor(support): rename search bar to search box
woowahan-pjs Oct 4, 2021
98597dd
refactor(mail): polish the code
woowahan-pjs Oct 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/kotlin/apply/application/EvaluationDtos.kt
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,11 @@ data class EvaluationTargetData(
)

data class MailTargetResponse(
val name: String,
val email: String
)
) {
constructor(applicantResponse: ApplicantResponse) : this(applicantResponse.name, applicantResponse.email)
}

data class EvaluationItemScoreData(
@field:NotNull
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/apply/application/MailTargetService.kt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class MailTargetService(
fun findMailTargets(evaluationId: Long, evaluationStatus: EvaluationStatus? = null): List<MailTargetResponse> {
val applicantIds = findEvaluationTargets(evaluationId, evaluationStatus).map { it.applicantId }
return applicantRepository.findAllById(applicantIds)
.map { MailTargetResponse(it.email) }
.map { MailTargetResponse(it.name, it.email) }
}

private fun findEvaluationTargets(evaluationId: Long, evaluationStatus: EvaluationStatus?): List<EvaluationTarget> {
Expand Down
12 changes: 12 additions & 0 deletions src/main/kotlin/apply/application/mail/MailSendData.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package apply.application.mail

import javax.validation.constraints.NotNull

data class MailSendData(
@field:NotNull
var subject: String = "",
@field:NotNull
var content: String = "",
@field:NotNull
var targetMails: List<String> = listOf()
)
4 changes: 3 additions & 1 deletion src/main/kotlin/apply/ui/admin/BaseLayout.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package apply.ui.admin

import apply.ui.admin.cheater.CheatersView
import apply.ui.admin.evaluation.EvaluationsView
import apply.ui.admin.mail.MailFormView
import apply.ui.admin.mission.MissionSelectionsView
import apply.ui.admin.recruitment.RecruitmentsView
import apply.ui.admin.selections.SelectionsView
Expand All @@ -27,7 +28,8 @@ class BaseLayout : AppLayout() {
"평가 관리" to EvaluationsView::class.java,
"과제 관리" to MissionSelectionsView::class.java,
"선발 과정" to SelectionsView::class.java,
"부정 행위자" to CheatersView::class.java
"부정 행위자" to CheatersView::class.java,
"메일 발송" to MailFormView::class.java
)

init {
Expand Down
114 changes: 114 additions & 0 deletions src/main/kotlin/apply/ui/admin/mail/GroupMailTargetFormDialog.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
package apply.ui.admin.mail

import apply.application.EvaluationService
import apply.application.MailTargetResponse
import apply.application.MailTargetService
import apply.application.RecruitmentResponse
import apply.application.RecruitmentService
import apply.domain.evaluation.Evaluation
import apply.domain.evaluationtarget.EvaluationStatus
import com.vaadin.flow.component.dialog.Dialog
import com.vaadin.flow.component.grid.Grid
import com.vaadin.flow.component.html.H2
import com.vaadin.flow.component.orderedlayout.FlexComponent
import com.vaadin.flow.component.orderedlayout.HorizontalLayout
import com.vaadin.flow.component.select.Select
import support.views.addSortableColumn
import support.views.createContrastButton
import support.views.createItemSelect
import support.views.createPrimaryButton

class GroupMailTargetFormDialog(
private val recruitmentService: RecruitmentService,
private val evaluationService: EvaluationService,
private val mailTargetService: MailTargetService,
private val reloadComponent: (List<MailTargetResponse>) -> Unit
) : Dialog() {
private val evaluation: Select<Evaluation> = createItemSelect("평가")
private val recruitment: Select<RecruitmentResponse> = createRecruitmentItem(evaluation)
private val evaluationStatus: Select<EvaluationStatus> = createEvaluationStatusItem(evaluation)
private val mailTargets: MutableList<MailTargetResponse> = mutableListOf()
private val currentMailTargetsGrid: Grid<MailTargetResponse> = createMailTargetsGrid()

init {
add(
H2("지원자 정보 조회"),
createMailTargetFilter(),
currentMailTargetsGrid,
createButtons()
)
width = "900px"
height = "70%"
open()
}

private fun createRecruitmentItem(evaluation: Select<Evaluation>): Select<RecruitmentResponse> {
return createItemSelect<RecruitmentResponse>("모집").apply {
setItems(*recruitmentService.findAll().toTypedArray())
setItemLabelGenerator { it.title }
addValueChangeListener {
evaluation.apply {
setItems(*evaluationService.findAllByRecruitmentId(it.value.id).toTypedArray())
setItemLabelGenerator { it.title }
}
}
}
}

private fun createEvaluationStatusItem(
evaluation: Select<Evaluation>,
): Select<EvaluationStatus> {
return createItemSelect<EvaluationStatus>("모집 상태").apply {
setItems(*EvaluationStatus.values())
setItemLabelGenerator { it.toText() }
addValueChangeListener {
val mailTargetResponses = mailTargetService.findMailTargets(evaluation.value.id, it.value)
mailTargets.clear()
mailTargets.addAll(mailTargetResponses)
currentMailTargetsGrid.apply {
setItems(mailTargetResponses)
}
}
}
}

private fun EvaluationStatus.toText() =
when (this) {
EvaluationStatus.WAITING -> "평가 전"
EvaluationStatus.PASS -> "합격"
EvaluationStatus.FAIL -> "탈락"
EvaluationStatus.PENDING -> "보류"
}

private fun createMailTargetsGrid(mailTargets: List<MailTargetResponse> = emptyList()): Grid<MailTargetResponse> {
return Grid<MailTargetResponse>(10).apply {
addSortableColumn("이름", MailTargetResponse::name)
addSortableColumn("이메일", MailTargetResponse::email)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적인 그리드에 메일 대상자 이름도 추가했다면 여기에서도 이름 컬럼을 추가하면 어떨까요???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요 여기에서도 이름을 추가하면 좋을 것 같아요 😃

setItems(mailTargets)
}
}

private fun createMailTargetFilter(): HorizontalLayout {
return HorizontalLayout(
recruitment, evaluation, evaluationStatus,
).apply {
element.style.set("margin-bottom", "10px")
}
}

private fun createButtons(): HorizontalLayout {
return HorizontalLayout(
createPrimaryButton("추가") {
reloadComponent(mailTargets)
close()
},
createContrastButton("취소") {
close()
}
).apply {
justifyContentMode = FlexComponent.JustifyContentMode.CENTER
defaultVerticalComponentAlignment = FlexComponent.Alignment.END
element.style.set("margin-top", "10px")
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
package apply.ui.admin.mail

import apply.application.ApplicantResponse
import apply.application.ApplicantService
import apply.application.MailTargetResponse
import com.vaadin.flow.component.Component
import com.vaadin.flow.component.button.Button
import com.vaadin.flow.component.dialog.Dialog
import com.vaadin.flow.component.grid.Grid
import com.vaadin.flow.component.html.H2
import com.vaadin.flow.component.orderedlayout.FlexComponent
import com.vaadin.flow.component.orderedlayout.HorizontalLayout
import com.vaadin.flow.data.renderer.ComponentRenderer
import com.vaadin.flow.data.renderer.Renderer
import support.views.addSortableColumn
import support.views.createContrastButton
import support.views.createPrimaryButton
import support.views.createSearchBar

class IndividualMailTargetFormDialog(
private val applicantService: ApplicantService,
private val reloadComponent: (MailTargetResponse) -> Unit
) : Dialog() {
private val currentMailTargetsGrid: Grid<ApplicantResponse> = createGrid()

init {
add(
H2("지원자 정보 조회"),
createMailTargetFilter(),
currentMailTargetsGrid
)
width = "900px"
height = "70%"
open()
}

private fun createGrid(applicantResponse: List<ApplicantResponse> = emptyList()): Grid<ApplicantResponse> {
return Grid<ApplicantResponse>(10).apply {
addSortableColumn("이름", ApplicantResponse::name)
addSortableColumn("이메일", ApplicantResponse::email)
addColumn(createAddButton()).apply { isAutoWidth = true }
setItems(applicantResponse)
}
}

private fun createAddButton(): Renderer<ApplicantResponse> {
return ComponentRenderer<Component, ApplicantResponse> { applicantResponse ->
HorizontalLayout(createMailTargetAddButton(applicantResponse))
}
}

private fun createMailTargetAddButton(applicantResponse: ApplicantResponse): Button {
return createPrimaryButton("추가") {
reloadComponent(MailTargetResponse(applicantResponse))
}.apply {
isDisableOnClick = true
}
}

private fun createMailTargetFilter(): Component {
return HorizontalLayout(
createSearchBar {
val founds = applicantService.findAllByKeyword(it)
currentMailTargetsGrid.apply {
setItems(founds)
}
},
createCancelButton()
).apply {
justifyContentMode = FlexComponent.JustifyContentMode.START
element.style.set("margin-top", "10px")
element.style.set("margin-bottom", "10px")
}
}

private fun createCancelButton(): Button {
return createContrastButton("취소") {
close()
}
}
}
Loading