Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mail): change to use amazon ses #185

Merged
merged 8 commits into from
Oct 18, 2020

Conversation

woowahan-pjs
Copy link
Contributor

Close #177, close #164

Copy link
Contributor

@dks301 dks301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key가 없어서 테스트를 돌려보지는 못했지만 이슈에 올려주신걸 보니 잘 작동하네요 👍
수고하셨습니다 :)

class ApplicationProperties {
lateinit var url: String
}
@ConstructorBinding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋ 불변의 삶

@@ -0,0 +1,5 @@
package apply.application.mail

interface MailSender {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

투표 결과대로 가면 여기가 ApplyMailSender가 되겠군요...!

Copy link
Contributor

@LTTTTTE LTTTTTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이메일 전송 잘 작동하네요!
테스트한다고 처음으로 awskey도 발급받아봤네요.
코드도 확장성있고 잘봤습니다👍🏼

Copy link
Contributor

@toneyparky toneyparky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

많이 배웠습니다 👍

class ApplicationProperties {
lateinit var url: String
}
@ConstructorBinding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋ 불변의 삶

@woowahan-pjs woowahan-pjs merged commit 69213e6 into develop Oct 18, 2020
@woowahan-pjs woowahan-pjs deleted the feature/send-email-using-ses branch October 18, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants