refactor: remove type attribute and use ...props instead

- Button - IconButton
woowacourse · Oct 4, 2022 · 420cfd1 · 420cfd1
1 parent b7dc136
commit 420cfd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/frontend/src/components/@common/Button/Button.tsx b/frontend/src/components/@common/Button/Button.tsx
@@ -17,7 +17,6 @@ const Button = ({
   className,
   variant = BUTTON_VARIANT.CONTAINED,
   cancel = false,
-  type,
   children,
   ...props
 }: ButtonProps) => {
@@ -26,7 +25,6 @@ const Button = ({
       className={classNames(className, styles[variant], styles.button, {
         [styles.cancel]: cancel,
       })}
-      type={type}
       {...props}
     >
       {children}

diff --git a/frontend/src/components/@common/IconButton/IconButton.tsx b/frontend/src/components/@common/IconButton/IconButton.tsx
@@ -6,9 +6,9 @@ export type IconButtonProps = React.ButtonHTMLAttributes<HTMLButtonElement> & {
   alt?: string;
 };
 
-const IconButton = ({ type, className, src, alt, ...props }: IconButtonProps) => {
+const IconButton = ({ className, src, alt, ...props }: IconButtonProps) => {
   return (
-    <button type={type} className={styles.button} {...props}>
+    <button className={styles.button} {...props}>
       <img src={src} alt={alt} className={className} />
     </button>
   );