Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1360 로드맵 답변 목록 검색 기능 추가 #1433

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Feature/1360 로드맵 답변 목록 검색 기능 추가 #1433

merged 9 commits into from
Aug 9, 2023

Conversation

java-saeng
Copy link
Contributor

@java-saeng java-saeng commented Jul 20, 2023 •
edited
Loading

#️⃣연관된 이슈

#1360

📝작업 내용

  • 로드맵의 답변들을 조회할 수 있다.
  • 커리큘럼(백, 프론트, 안드), 제일 하위 키워드(동일성과 동등성, enum ...), 퀴즈, 멤버로 필터링하여 조회할 수 있다.

close #1360

@java-saeng java-saeng added BE 로드맵 로드맵 스쿼드 관련 이슈 labels Jul 20, 2023
@java-saeng java-saeng requested review from amaran-th and nuyh99 July 20, 2023 07:20
@splitCoding splitCoding deleted the branch roadmap-develop July 28, 2023 08:39
@java-saeng java-saeng reopened this Aug 3, 2023
@java-saeng java-saeng changed the base branch from develop to roadmap-develop August 3, 2023 07:15
amaran-th
amaran-th requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~! 몇 가지 신경쓰이는 부분이 있어 코멘트 남겨두었습니다!
확인 후 다시 리뷰 요청 부탁드려요~

backend/src/main/java/wooteco/prolog/roadmap/application/EssayAnswerService.java Outdated Show resolved Hide resolved
backend/src/main/java/wooteco/prolog/roadmap/application/EssayAnswerService.java Outdated Show resolved Hide resolved
backend/src/test/java/wooteco/prolog/roadmap/application/EssayAnswerSearchTest.java Show resolved Hide resolved
backend/src/test/java/wooteco/prolog/roadmap/application/EssayAnswerSearchTest.java Show resolved Hide resolved
backend/src/test/java/wooteco/prolog/roadmap/application/EssayAnswerSearchTest.java Show resolved Hide resolved
@Cl8D
Copy link
Contributor

Cl8D commented Aug 7, 2023

리뷰 반영 완료했습니다~!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.0% 83.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Cl8D Cl8D merged commit 703ffb7 into roadmap-develop Aug 9, 2023
@Cl8D Cl8D deleted the feature/1360-로드맵_답변_목록_검색_기능_추가 branch August 9, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaran-th amaran-th amaran-th approved these changes

@nuyh99 nuyh99 Awaiting requested review from nuyh99

Assignees

@Cl8D Cl8D

@java-saeng java-saeng

Labels
BE 로드맵 로드맵 스쿼드 관련 이슈
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@java-saeng @Cl8D @amaran-th @splitCoding