fix(article): change sort criteria to take into account publishedAt

woowacourse · Jun 5, 2024 · f1f9d86 · f1f9d86
1 parent e44c3c7
commit f1f9d86
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/backend/src/main/java/wooteco/prolog/article/application/ArticleService.java b/backend/src/main/java/wooteco/prolog/article/application/ArticleService.java
@@ -107,6 +107,12 @@ public List<ArticleResponse> getFilteredArticles(final LoginMember member,
             .collect(toList());
     }
 
+    public List<ArticleResponse> getArticlesByPublishedAt(final LoginMember member) {
+        return articleRepository.findAllOrderByPublishedAtOrCreatedAt().stream()
+            .map(article -> ArticleResponse.of(article, member.getId()))
+            .collect(toList());
+    }
+
     @Transactional
     public void updateViewCount(final Long id) {
         final Article article = articleRepository.findById(id)

diff --git a/backend/src/main/java/wooteco/prolog/article/domain/repository/ArticleRepository.java b/backend/src/main/java/wooteco/prolog/article/domain/repository/ArticleRepository.java
@@ -12,6 +12,9 @@ public interface ArticleRepository extends JpaRepository<Article, Long> {
 
     List<Article> findAllByOrderByCreatedAtDesc();
 
+    @Query("SELECT a FROM Article a ORDER BY COALESCE(a.publishedAt, a.createdAt) desc")
+    List<Article> findAllOrderByPublishedAtOrCreatedAt();
+
     @Query("select a from Article a join fetch a.articleBookmarks where a.id = :id")
     Optional<Article> findFetchBookmarkById(@Param("id") final Long id);
 

diff --git a/backend/src/main/java/wooteco/prolog/article/ui/ArticleController.java b/backend/src/main/java/wooteco/prolog/article/ui/ArticleController.java
@@ -69,10 +69,10 @@ public ResponseEntity<Void> likeArticle(@PathVariable final Long id,
     }
 
     @GetMapping
-    public ResponseEntity<List<ArticleResponse>> getFilteredArticles(@AuthMemberPrincipal final LoginMember member,
+    public ResponseEntity<List<ArticleResponse>> getArticlesByPublishedAt(@AuthMemberPrincipal final LoginMember member,
                                                                 @RequestParam("course") final ArticleFilterType course,
                                                                 @RequestParam("onlyBookmarked") boolean onlyBookmarked) {
-        final List<ArticleResponse> articleResponses = articleService.getFilteredArticles(member, course, onlyBookmarked);
+        final List<ArticleResponse> articleResponses = articleService.getArticlesByPublishedAt(member);
 
         return ResponseEntity.ok(articleResponses);
     }