[예지니어스] 4단계 - HTTP 웹 서버 리팩토링 미션 제출합니다. #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeyeonling
requested changes
Nov 21, 2020
|
|
||
| public class Application { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(RequestHandler.class); |
There was a problem hiding this comment.
RequestHandler의 로거를 생성하는 것은 의도된 내용일까요?
|
|
||
| private final static FrontController FRONT_CONTROLLER; | ||
|
|
||
| static { |
There was a problem hiding this comment.
프로덕션 코드와 중복이 되네요!
지금의 구조에서 코드의 변경사항이 있다면 테스트 코드도 계속해서 반영해줘야하는 문제가 생길 수 있습니다.
중복을 제거하고 동일한 초기화 과정을 하도록 수정해보면 어떨까요?
| private static final int DEFAULT_PORT = 8080; | ||
| private static final int CORES = Runtime.getRuntime().availableProcessors(); | ||
|
|
||
| public static void main(String args[]) throws Exception { | ||
| public static void main(String[] args, Controller controller) throws Exception { |
There was a problem hiding this comment.
자바의 메인 메서드는 JVM의 EntryPoint 규칙으로 보면 되는데요.
지금과 같이 시그니처가 변경된 경우 더 이상 메인 메서드의 역할을 할 수 없게 됩니다!
그렇다면 WebServer를 main으로 제공할 필요가 있을지 고민해보면 어떨까요?
추가적으로 WebServer의 라이프 사이클은 어떻게 관리할까? 에 대한 고민도 해보면 좋을 것 같습니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 재연링!
HTTP 웹 서버 리팩토링 4단계 멀티모듈 적용 미션 제출합니다 🙂
크게 웹 서버 역할을 담당하는 server-module 과 사용자 애플리케이션이 담길 application-module로 모듈 분리했어요.
감사합니다.