[범블비] 3단계 - HTTP 웹 서버 구현 미션 제출합니다. #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave915
suggested changes
Nov 18, 2020
| import java.util.stream.Stream; | ||
|
|
||
| public class HttpSessionStorage { | ||
| private static Map<UUID, HttpSession> sessions = new HashMap<>(); |
There was a problem hiding this comment.
sessions 에는 여러 Request Thread가 동시에 접근 가능하기 때문에
HashMap 보단 ConcurrentHashMap 이 Thread Safe 할 것 같아요 :)
Comment on lines
24
to
26
| public void invalidate() { | ||
| attributes.clear(); | ||
| } |
There was a problem hiding this comment.
session의 invalidate 메소드가 호출된 후에는 해당 세션은 사용하지 못하는 것으로 알고 있어요.
아래 링크 한번 읽어보시고, 한번 검색해보시면 좋을 것 같아요 :)
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| public class AuthFilter implements Filter { |
dave915
suggested changes
Nov 24, 2020
| public class HttpSession { | ||
| private UUID id = UUID.randomUUID(); | ||
| private boolean isValid = true; | ||
| private Map<String, Object> attributes = new HashMap<>(); |
There was a problem hiding this comment.
유저가 로그인 된 상태에서 클라이언트가 api를 병렬로 요청한다면 attributes에도 동시성 이슈가 발생 할 가능성이 있을 것 같아요 :)
Comment on lines
+13
to
+23
| public void setAttribute(String name, Object value) { | ||
| attributes.put(name, value); | ||
| } | ||
|
|
||
| public Object getAttribute(String name) { | ||
| return attributes.get(name); | ||
| } | ||
|
|
||
| public void removeAttribute(String name) { | ||
| attributes.remove(name); | ||
| } |
There was a problem hiding this comment.
isValid 메소드가 있긴 하지만 isValid메소드로 확인하지 않는 경로로 해당 Session을 얻었다면 기존대로 사용 가능 할 것 같아요.
각 메소드 마다 valid 체크를 한 후 오류를 던져주도록 하면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
너무 오랜만에 보내네요 ㅠㅠ 잘부탁드립니다!