[라빈] - 체스 스프링 실습 레벨 1 제출합니다 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimGyeong
approved these changes
Apr 22, 2020
| post("/destination", this::move, json()); | ||
| } | ||
|
|
||
| private String index(Request req, Response res) { |
There was a problem hiding this comment.
메서드의 컨벤션은 동사라는 피드백을 받은 적이 있습니다. 변경해보는 것은 어떨까요?
| try (PreparedStatement pstmt = connectionManager.getConnection().prepareStatement(query); ResultSet rs = pstmt.executeQuery()) { | ||
| public List<MovingPosition> selectAll() throws SQLException { | ||
| String query = "SELECT * FROM history"; | ||
| try (PreparedStatement pstmt = connectionManager.getConnection().prepareStatement(query); ResultSet rs = pstmt.executeQuery()) { |
woowahan-pjs
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작은곰 안녕하세요!
기존에 작성했던 코드에서 콘솔 관련된 부분을 삭제하고 리팩토링 후 제출합니다.
감사합니닿ㅎㅎㅎ