-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[라빈] 체스 스프링 4단계 미션 제출합니다. #195
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
31cfa7b
docs: README.md 수정 - 레벨 4
toneyparky 1839c71
feat: 데이터베이스 스키마 업데이트
toneyparky c8c9d31
feat: 테스트용 데이터베이스 설정
toneyparky d332025
feat: 게임 생성 후 DB에 저장 기능 구현
toneyparky 520568e
feat: 게임 DB에 조회 기능 구현
toneyparky f8faa6b
style: 컨벤션을 위한 수정
toneyparky 9fd31b8
feat: game 업데이트 기능 구현
toneyparky 2435e2d
feat: history 추가 구현
toneyparky 050afe4
feat: Game에 해당하는 히스토리 전체 조회
toneyparky 66f72e8
fix: 종료된 게임은 전체 조회 목록에서 제외하도록 수정
toneyparky e81e513
feat: 게임을 생성하고 해당 게임을 불러오는 기능 추가
toneyparky 7f2ad79
style: javascript 컨벤션을 지키기 위해 4칸에서 2칸으로 탭 수정
toneyparky 940776c
feat: move와 loading 관련 api에 gameId를 이용하도록 구현
toneyparky fec4be2
feat: 게임이 종료되면 결과 페이지로 넘어가는 기능 구현
toneyparky c742427
feat: 진행가능한 게임 목록을 보여주는 기능 구현
toneyparky a7e61d6
feat: 게임 중 나가기 기능 추가
toneyparky 671275c
refactor: 사용하지 않는 레포지토리 제거
toneyparky c8321e5
style: index.hbs 뷰 수정
toneyparky 819034e
style: chess.hbs, result.hbs 뷰 수정
toneyparky 485b2b8
fix: 게임 이름을 입력하지 않으면 빈 보드로 넘어가는 버그 수정
toneyparky 7247b44
style: 프로젝트 전체 파일 컨벤션 수정
toneyparky 22c8587
fix: 사용자가 데이터베이스에 저장되어 있지 않은 게임 아이디로 정보를 전달할 때 예외 처리 기능 구현
toneyparky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package wooteco.chess.dto; | ||
|
||
import java.util.Collections; | ||
import java.util.Map; | ||
|
||
public class GamesDto { | ||
private final Map<Long, String> games; | ||
|
||
public GamesDto(Map<Long, String> games) { | ||
this.games = games; | ||
} | ||
|
||
public Map<Long, String> getGames() { | ||
return Collections.unmodifiableMap(games); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://madplay.github.io/post/why-constructor-injection-is-better-than-field-injection
의존성 주입에 대한 방법에 대해 생각해보면 좋을 것 같아요 :)