-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 콘솔 기반 로또 게임] 초코(강다빈) 미션 제출합니다. #290
Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
9bb5a9e
docs REQUIREMENTS.md 생성
vi-wolhwa 656df6c
docs: test
00kang 85feae0
docs: test 하기
00kang a1f4355
docs: 기능 구현 목록 작성
00kang e8c8231
chore: eslint, prettier 설정 및 package 정보 변경
00kang 812e848
test: 구입 금액에 따른 로또 발행 테스트 작성
00kang 8010ff6
chore: eslint 플러그인 재설치
vi-wolhwa 725f690
feat: 구입금액에 따른 발행 수량 계산
vi-wolhwa 916057e
feat: 랜덤 유틸 클래스 구현
vi-wolhwa d90568f
feat: 수량 만큼 로또 발행
vi-wolhwa 6e11789
feat: 로또 객체 생성 및 번호 정렬
vi-wolhwa f689337
feat: 당첨 결과 분석, 순위 반환
vi-wolhwa 3885553
style: printWidth 변경 (80 -> 100)
vi-wolhwa 41e3459
feat: 당첨 결과 분석 및 순위 반환
vi-wolhwa be26777
refactor: 로또 등수 계산 로직 분리
vi-wolhwa e7aac4b
refactor: 상수명 변경
vi-wolhwa f9d2c32
feat: 콘솔 입력 구현
vi-wolhwa 03ee900
feat: controller, model, view 연결
vi-wolhwa 993ff65
feat: README.md 수정
00kang 7cf4395
style: 입,출력 메시지의 스타일 수정
00kang 6804840
feat: 로또 발행 메서드 컨트롤러에 연결
00kang ea9485a
fix: 컨트롤러에서 당첨번호 입력 기능의 inputWinningNumbers 메서드 수정
00kang a1eb586
fix: 당첨 통계 결과 반환 안되는 오류 수정
00kang 21e5888
fix: 발행된 로또 오름차순 정렬하여 보여주도록 수정
00kang ff23a3a
feat: 실행결과 사진 포함하여 README.md 수정
00kang e1572cf
feat: 구입 금액에 대한 유효성 검사 진행 및 재입력받도록 추가구현
00kang de926bc
feat: 당첨 번호 입력에 대한 유효성 검사 진행 및 재입력받도록 추가구현
00kang 788cbf0
feat: 보너스 점수 입력에 대한 유효성 검사 추가 구현
00kang cb70b91
feat: 게임 재시작 및 유효성 검사 추가 구현
00kang 184aacf
feat: REQUIREMENTS.md 업데이트
00kang ed22aa4
refactor: 컨트롤러로 이동
00kang 27c944d
refactor: 프로그래밍 요구사항에 맞게 eslint 재설치 및 수정
00kang 1b86786
refactor: eslint max-params 규칙에 따라 수정
00kang b573410
refactor: eslint max-lines-per-function 규칙에 따라 LottoController 내의 메서드 분리
00kang c681e4a
refacotr: airbnb 컨벤션에 따라 isNan 대신 Number.isNan으로 수정
00kang dfe9bb0
refacotr: nullish coalescing operator(??) 사용으로 불필요한 비교 줄임
00kang e7b65d9
refactor: eslint max-params 규칙에 따라 객체로 묶는 수정
00kang 979af80
feat:winningNumbers와 bonusNumber를 배열로 반환하여 당첨 결과 출력 오류 수정
00kang f501d39
refactor: eslint max-depth 규칙에 따라 메서드 분리
00kang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기왕 수정한거 그냥 isNaN과 Number.isNaN의 차이점도 정리하고가면 좋겠네요~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isNaN
Number.isNaN