Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2단계 - 사다리 타기] 이든(최승준) 미션 제출합니다. #366

Merged
merged 40 commits into from
Mar 1, 2024
Merged

[2단계 - 사다리 타기] 이든(최승준) 미션 제출합니다. #366

merged 40 commits into from
Mar 1, 2024

Commits on Feb 28, 2024

  1. refactor : 클래스명이 의미를 더 잘 표현하도록 수정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    65cc025 View commit details
    Browse the repository at this point in the history

  2. refactor : 오라클 자바 컨벤션에 맞도록 클래스 멤버 위치 조정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7226a19 View commit details
    Browse the repository at this point in the history

  3. refactor : 중복되는 네이밍 변경 

    generate -> generateBridge
    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d8cbe46 View commit details
    Browse the repository at this point in the history

  4. refactor : BridgeGeneratorStub 클래스, NPE 문제 방지

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9ab2f29 View commit details
    Browse the repository at this point in the history

  5. remove : 입력 테스트 제거

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8cc519d View commit details
    Browse the repository at this point in the history

  6. docs : Step2 기능 구현 문서 추가

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b46f1d5 View commit details
    Browse the repository at this point in the history

  7. feat : 사다리 결과 출력 기능 구현

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    94292ee View commit details
    Browse the repository at this point in the history

  8. refactor : 참가자 이름 입력 시, 구분자가 가장 마지막에 오는 경우 검증하도록 수정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4c13691 View commit details
    Browse the repository at this point in the history

  9. refactor : 패키지 구조 변경

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d52cf71 View commit details
    Browse the repository at this point in the history

  10. feat : 사다리 실행 결과 확인 기능 구현

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    55d9d3d View commit details
    Browse the repository at this point in the history

  11. refactor : CustomException 제거 

    - 사용하는 이유가 따로 없기 때문에 RuntimeException 바로 상속받도록 변경
    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    585db12 View commit details
    Browse the repository at this point in the history

  12. refactor : 예외 메시지는 발생시키는 곳에서 관리하도록 변경 

    경# feat : 기능 추가
    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fef4282 View commit details
    Browse the repository at this point in the history

  13. refactor : 상수 네이밍 깔끔하게 변경

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c021e37 View commit details
    Browse the repository at this point in the history

  14. refactor : 중복되는 bridge 랜덤 생성 로직 메서드 분리

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fa2fd59 View commit details
    Browse the repository at this point in the history

  15. remove : 의미없는 상수 제거

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0f8e40f View commit details
    Browse the repository at this point in the history

  16. feat : 사용할 수 없는 이름 추가

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e44fd39 View commit details
    Browse the repository at this point in the history

  17. refactor : 재입력 메서드 네이밍 동일하게 변경(오버로딩)

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    027deda View commit details
    Browse the repository at this point in the history

  18. refactor : 커맨드 관련 상수 열거 클래스로 분리 

    PlayerName이 Command에 포함되는 text인지 검증하기 위해 Command Enum 생성
    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    62b6580 View commit details
    Browse the repository at this point in the history

  19. refactor : 필드명으로 value 사용

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a61097e View commit details
    Browse the repository at this point in the history

  20. refactor : 불필요한 확장성을 위해 만든 RetryableController 삭제

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c22e650 View commit details
    Browse the repository at this point in the history

  21. refactor : InputView에서만 사용되는 상수에 private 접근 제어 설정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6e8f2cf View commit details
    Browse the repository at this point in the history

  22. refactor : 코드라인 정리

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c38d1bd View commit details
    Browse the repository at this point in the history

  23. refactor : 코드 컨벤션에 맞춰 클래스 멤버 위치 조정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3dfe45e View commit details
    Browse the repository at this point in the history

  24. refactor : ui 로직에 의존하던 LadderBridge enum 코드 제거 

     outputView의 Map에서 bridgeMarker 관리
    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    17f859e View commit details
    Browse the repository at this point in the history

  25. refactor : Players 사다리 결과 형식 상수화 

    "실행 결과"와 같이 의미하는 바가 확실한 일반 문자열은 따로 상수화해주지 않아도 알아보기 편하지만 "%d %s" 등과 같은 format은 이름없이 존재하면 의미를 파악하기 어렵기 때문에 상수화를 통해 관리
    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d44bbbd View commit details
    Browse the repository at this point in the history

  26. docs : 사다리 종료 커멘드 관련 문서 수정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bca81d8 View commit details
    Browse the repository at this point in the history

  27. remove : LadderBridge getter 삭제

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9543acc View commit details
    Browse the repository at this point in the history

  28. refactor : 오라클 컨벤션에 맞게 멤버 위치 변경

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    65a578c View commit details
    Browse the repository at this point in the history

  29. refactor : 테스트 클래스 위치, 네이밍 수정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ea3e039 View commit details
    Browse the repository at this point in the history

  30. refactor : 테스트 내부 클래스로 분리

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    04f71c7 View commit details
    Browse the repository at this point in the history

  31. refactor : 중복 로직 메서드 분리

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    48c6982 View commit details
    Browse the repository at this point in the history

  32. refactor : final 키워드 사용해서 재할당 불가능하게 수정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5c2a355 View commit details
    Browse the repository at this point in the history

  33. refactor : final 키워드 사용해서 재할당 불가능하게 수정

    @PgmJun
    PgmJun committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    dc65b6e View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. refactor : 직관적인 에러 메시지 네이밍 사용

    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7b9f32b View commit details
    Browse the repository at this point in the history

  2. refactor : ealry return 적용하여 else 키워드 제거

    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4359d9d View commit details
    Browse the repository at this point in the history

  3. refactor : Ladder의 책임 분리 

    현재와 같이 설계하면 같은 사다리에 다른 사람들과, 다른 결과들을 넣고싶다면 새로운 Ladder 객체를 생성해야 함
때문에 굳이 Ladder가 PlayerNames와 LadderResults를 알고 있어야한다는 책임을 주는 것보다 사다리 결과를 얻는 match 메서드에서 메서드 인자로 필요할 때 받아서 사용하는 것이 더 적합하다고 생각
    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    120d838 View commit details
    Browse the repository at this point in the history

  4. refactor : 한번에 index, name 조회해오도록 변경

    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f96ca82 View commit details
    Browse the repository at this point in the history

  5. refactor : 클래스 변수, 인스턴스 변수 구분

    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9b281d0 View commit details
    Browse the repository at this point in the history

  6. refactor : n번 조회 방식에서 단일 조회 방식으로 변경

    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1ba0367 View commit details
    Browse the repository at this point in the history

  7. refactor : OS 별로 다른 이스케이프 문자 고려하여 코드 수정

    @PgmJun
    PgmJun committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9670383 View commit details
    Browse the repository at this point in the history