Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[라빈] API 테스트/문서자동화 미션 제출합니다 #9

Merged
merged 31 commits into from
Jun 2, 2020

Conversation

giantim
Copy link

@giantim giantim commented May 26, 2020

감사합니다!

giantim and others added 30 commits May 19, 2020 17:46
 email과 name, password에 @notblank 적용
 InvalidMemberEmailException, InvalidMemberIdException, DuplicateEmailException 생성
Copy link

@jihan805 jihan805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 깔끔하게 구현 잘하셨어요 💯
피드백 남겼으니 확인해주세요!

Copy link

@jihan805 jihan805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 피드백 반영 모두 잘해주셨네요 👍
머지할게요, 고생 많으셨습니다!

@jihan805 jihan805 merged commit 3983563 into woowacourse:giantim Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants