-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] refactor: 서비스 리팩터링 #540
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1e6204b
feat: 리뷰를 검증하는 서비스 구현
Kimprodp d62a842
refactor: 리뷰 등록 서비스가 리뷰를 생성하고 검증 서비스를 통해서 검증하도록 변경
Kimprodp de03539
refactor: 답변 검증 서비스가 요청이 아닌 객체를 검증하도록 변경
Kimprodp 2fc94e1
feat: 리뷰에서 제공하는 기능 추가
Kimprodp 7561c72
refactor: dto명 변경 및 사용하지 않는 메서드 삭제
Kimprodp d3842d2
refactor: 예외명 및 메세지 변경
Kimprodp 3cfe514
refactor: 리뷰 목록 조회 서비스명 변경 및 응답 객체 mapper를 활용하도록 변경
Kimprodp daecbdc
feat: 리뷰 목록 응답 객체 매핑 서비스 추가
Kimprodp 9cc53a9
refactor: dto명 변경으로 인한 수정
Kimprodp b60807f
refactor: ReviewMapper를 통해 리뷰를 생성하도록 변경
Kimprodp ebc281c
refactor: 리뷰 상세 응답 mapper를 활용하도록 변경 및 일부 로직 리팩터링
Kimprodp e42293c
refactor: 템플릿을 찾는 로직을 mapper에서 하도록 변경
Kimprodp 357e9ef
refactor: 리팩터링에 따른 컨트롤러 변경사항
Kimprodp bb153e5
Merge remote-tracking branch 'refs/remotes/origin/develop' into be/re…
Kimprodp 646d8b7
test: 변경사항 반영
Kimprodp 20d6ffc
refactor: 질문이 없는 섹션은 응답 생성하지 않도록 변경
Kimprodp bd4b455
refactor: 답변이 null인 경우에 대한 예외 추가
Kimprodp fd2f730
refactor: CheckBoxAnswerValidator null 검증 제외 및 질문 유효 검증 추가
Kimprodp 14e1819
refactor: TextAnswerValidator 질문 유효 검증 추가
Kimprodp 76a01c7
test: Validator 테스트 작성
Kimprodp 08e5707
test: Mapper 테스트 작성
Kimprodp 7e15fa3
test: ReviewValidator 테스트 작성
Kimprodp 8726e0c
test: ReviewRegisterService 테스트 간소화
Kimprodp cfe4fd9
test: 리팩터링 사항 반영
Kimprodp c351eb2
test: Review 테스트 작성
Kimprodp 4ff1bb4
chore: secret 변경사항 반영
Kimprodp f494164
refactor: 답변 생성 시, null 이 들어올 수 없도록 변경
Kimprodp b0e20bc
refactor: ReviewMapper 에서 답변에 대한 검증 없이 엔티티 매핑만 하도록 변경
Kimprodp 0d63f18
refactor: ReviewValidator 에서 답변에 대한 검증도 진행하도록 변경
Kimprodp d93f943
refactor: 메서드명 변경 (getAllQuestionIdsFromAnswers -> getAnsweredQuestio…
Kimprodp 6363b82
refactor: @Transactional 어노테이션을 클래스 범위에만 적용하도록 변경
Kimprodp 0062fb4
refactor: 메서드 분리 변경
Kimprodp 1359b10
refactor: 메서드 시그니쳐 변경
Kimprodp 8caa2b0
style : 개행 수정
Kimprodp b90aa47
refactor: 존재하는 메서드 활용하도록 변경
Kimprodp 1f18e77
refactor: 리뷰에 특적 질문에 대한 답변이 있는지 확인하는 기능 추가
Kimprodp 0071013
style: 개행 수정
Kimprodp 7022bcb
refactor: 객체 메서드를 활용하도록 변경
Kimprodp c280809
test: AnswerMapperTest 작성
Kimprodp d9b4519
refactor: 답변 검증 시, 답변이 빈 경우에 대한 검증도 객체 생성자에서 진행 및 QuestionNotAnswered…
Kimprodp caa0716
refactor: 메서드명 변경 (hasQuestions -> hasAnsweredQuestion)
Kimprodp eca9491
style: 개행 변경
Kimprodp 591f8cb
refactor: ReviewValidator 파라미터를 나눠보 보낼 수 있는 부분 적용
Kimprodp d3a615c
Merge remote-tracking branch 'refs/remotes/origin/develop' into be/re…
Kimprodp 610b785
test: develop 브랜치 머치 후, 미변경 사항 적용
Kimprodp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 10 additions & 5 deletions
15
backend/src/main/java/reviewme/review/service/module/TextAnswerValidator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 어렵네요,, 각 서술형 답변마다 다시 DB를 찌르게 될 듯해요. 😨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
위에 말씀드린 DB 접근 최소화 리팩토링에 함께 진행하겠습니다~