Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 필수 질문 제출 검증 #502

Merged
merged 18 commits into from
Aug 21, 2024
Merged

[BE] 필수 질문 제출 검증 #502

merged 18 commits into from
Aug 21, 2024

Conversation

nayonsoso
Copy link
Contributor

@nayonsoso nayonsoso commented Aug 21, 2024 •
edited
Loading

🚀 어떤 기능을 구현했나요 ?

  • 필수 질문에 대해서 검증합니다.

🔥 어떻게 해결했나요 ?

  1. 리뷰 생성 요청 dto에서 선택한 모든 optionItem 을 가져옵니다.
  2. 리뷰 생성 요청 dto에서 응답한 모든 questionId 를 가져옵니다.
  3. 템플릿에서 섹션을 조회합니다.
  4. 섹션의 onSelectedId 에 1번의 optionItem 이 해당되거나, isVisiable 이 ALWAYS 인 섹션의 모든 질문 id 를 가져옵니다.
  5. 2에서 받아온 제출한 모든 질문에 4에서 받아온 필수로 응답해야 하는 질문이 포함되지 않는다면, 예외를 발생시킵니다.
  6. 4에서 받아온 필수로 응답해야 하는 질문을 벗어나는 2에서 받아온 질문이 있다면, 예외를 발생시킵니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 아주 절차지향적인 코드를 작성했습니다. 개선할 부분이 많이 보일 것 같아요.

📚 참고 자료, 할 말

@nayonsoso nayonsoso changed the title [BE] 452 2 required answer validation [BE] 필수 질문 제출 검증 Aug 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Test Results

82 tests  +1   82 ✅ +1   4s ⏱️ -1s
24 suites ±0    0 💤 ±0 
24 files   ±0    0 ❌ ±0 

Results for commit eabebb9. ± Comparison against base commit d91c7a6.

♻️ This comment has been updated with latest results.

@nayonsoso nayonsoso requested review from skylar1220, donghoony and Kimprodp and removed request for skylar1220 and donghoony August 21, 2024 07:29
@nayonsoso nayonsoso added this to the 4차 스프린트: 최종 milestone Aug 21, 2024
Kimprodp
Kimprodp approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 고새했슴니다

donghoony
donghoony requested changes Aug 21, 2024
View reviewed changes
backend/src/main/java/reviewme/review/service/CreateReviewService.java Outdated Show resolved Hide resolved
backend/src/main/java/reviewme/review/service/CreateReviewService.java Outdated Show resolved Hide resolved
backend/src/main/java/reviewme/review/service/CreateReviewService.java Outdated Show resolved Hide resolved
backend/src/main/java/reviewme/review/service/CreateReviewService.java Outdated Show resolved Hide resolved
backend/src/main/java/reviewme/review/service/exception/MissingRequiredQuestionException.java Show resolved Hide resolved
...nd/src/main/java/reviewme/review/service/exception/UnnecasseryQuestionIncludedException.java Outdated Show resolved Hide resolved
backend/src/main/java/reviewme/review/service/CreateReviewService.java Outdated Show resolved Hide resolved
donghoony
donghoony approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@donghoony donghoony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

산: 너무 고생했습니다 산초
초: 리팩터링은 같이 고민해봐요~

@nayonsoso nayonsoso merged commit c3c4169 into develop Aug 21, 2024
2 checks passed
@donghoony donghoony deleted the 452-2-required-answer-validation branch August 21, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@donghoony donghoony donghoony approved these changes

Assignees

@nayonsoso nayonsoso

@skylar1220 skylar1220

Labels
✨ BE 우선순위: 상 💪 아자아자!! 🚀 기능
Projects
2024-review-me
Status: Done
Milestone
4차 스프린트: 최종
Development

Successfully merging this pull request may close these issues.

[BE] 필수 응답을 하지 않은 경우의 검증을 추가한다.
4 participants
@nayonsoso @donghoony @skylar1220 @Kimprodp