Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] fix: Pretendard 오류 수정 #386

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[FE] fix: Pretendard 오류 수정 #386

merged 1 commit into from
Aug 16, 2024

Conversation

BadaHertz52
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

오류 설명

현재 Pretendard 의 font family이 잘못 설정되어서 Pretendard가 아닌 Noto sans 가 적용되고 있어요.

🔥 어떻게 해결했나요 ?

  • Pretendard 의 font family 설정을 올바르게 변경했어요.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 피그마에 있는 Pretendard 와 같은 폰트가 적용되었는지 확인해주세요.

📚 참고 자료, 할 말

  • 폰트 cdn을 들어가서 보자
  • 마위네 버그 잡아주다가 우리 코드 버그도 발견함-> 결론: 착하게 살면 복이 온다.😊

@BadaHertz52 BadaHertz52 added this to the 4차 스프린트: 최종 milestone Aug 16, 2024
@BadaHertz52 BadaHertz52 self-assigned this Aug 16, 2024
@BadaHertz52 BadaHertz52 linked an issue Aug 16, 2024 that may be closed by this pull request
[FE] Pretendard 오류를 수정한다. #385
Closed
soosoo22
soosoo22 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우!! 드디어 Pretendard가 적용이 되는 거네요!!

ImxYJL
ImxYJL approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^_^b

chysis
chysis approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noto Sans가 적용되고 있던 문제가 해결되었군요!

@BadaHertz52 BadaHertz52 merged commit 47a7f70 into develop Aug 16, 2024
5 checks passed
@BadaHertz52 BadaHertz52 deleted the fe/fix/385-pretendard branch August 28, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImxYJL ImxYJL ImxYJL approved these changes

@soosoo22 soosoo22 soosoo22 approved these changes

@chysis chysis chysis approved these changes

Assignees

@BadaHertz52 BadaHertz52

Labels
🍀 FE 🎨 디자인 🐛 버그
Projects
2024-review-me
Status: Done
Milestone
4차 스프린트: 최종
Development

Successfully merging this pull request may close these issues.

[FE] Pretendard 오류를 수정한다.
4 participants
@BadaHertz52 @chysis @soosoo22 @ImxYJL