Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] refactor: 리뷰 작성 시 네이티브 쿼리를 사용 #308

Merged
merged 4 commits into from
Aug 12, 2024
Merged

[BE] refactor: 리뷰 작성 시 네이티브 쿼리를 사용 #308

merged 4 commits into from
Aug 12, 2024

Conversation

donghoony
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

🔥 어떻게 해결했나요 ?

  • 네이티브 쿼리 작성, 테스트 작성

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 쿼리가 잘 작성되었는지, 테스트 잘 짜였는지 확인해주세요

@donghoony donghoony added this to the 4차 스프린트: 최종 milestone Aug 12, 2024
@donghoony donghoony self-assigned this Aug 12, 2024
@donghoony donghoony linked an issue Aug 12, 2024 that may be closed by this pull request
[BE] 데이터 조회에 여러 번 쿼리가 발생하는 것을 네이티브 쿼리로 최적화한다. #307
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Test Results

58 tests  +1   58 ✅ +1   2s ⏱️ ±0s
22 suites ±0    0 💤 ±0 
22 files   ±0    0 ❌ ±0 

Results for commit 29ff0b2. ± Comparison against base commit c2b75de.

♻️ This comment has been updated with latest results.

@donghoony donghoony changed the title [BE] 리뷰 작성 시 네이티브 쿼리를 사용 [BE] refactor: 리뷰 작성 시 네이티브 쿼리를 사용 Aug 12, 2024
Kimprodp
Kimprodp approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

backend/src/main/java/reviewme/review/repository/QuestionRepository2.java Outdated
ON sq.section_id = ts.section_id
WHERE ts.template_id = :templateId
""", nativeQuery = true)
Set<Long> findAllQuestionIdByTemplateId(Long templateId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여긴 Long 인 이유가 있을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(산초 말투로) 웁스!

skylar1220
skylar1220 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나도 네이티브 쿼리 잘 하고 싶다!! 지금 고민 중인 네이티브 쿼리에 참고해봐야지!
오늘의 일기 끝📝

@donghoony donghoony merged commit d5b8cb6 into develop Aug 12, 2024
4 checks passed
@donghoony donghoony deleted the be/refactor/307-native-query-on-create-review branch August 16, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

Assignees

@donghoony donghoony

Labels
✨ BE 🛠️ 리팩터링
Projects
2024-review-me
Status: Done
Milestone
4차 스프린트: 최종
Development

Successfully merging this pull request may close these issues.

[BE] 데이터 조회에 여러 번 쿼리가 발생하는 것을 네이티브 쿼리로 최적화한다.
4 participants
@donghoony @nayonsoso @skylar1220 @Kimprodp