Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] feat : ErrorSuspense에 fallback 수정 #1027

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

BadaHertz52
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • ErrorSuspense 에 Suspense fallback을 props로 받을 수 있게 해서 Suspense 활용도를 높였습니다.
    그 과정에서 기존의 ErrorBoundary fallback props명을 수정했습니다.

🔥 어떻게 해결했나요 ?

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

  • 리뷰 링크 생성폼 PR에 해당 PR 내용이 포함되어 있어서, 이 PR를 먼저 머지해주세요!

- Suspense fallback을 props로 받을 수 있게 하면서, 기존의 ErrorBoundary fallback props명 수장
Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳~

Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻🔥

@BadaHertz52 BadaHertz52 merged commit 4d0fe93 into develop Jan 5, 2025
5 checks passed
@BadaHertz52 BadaHertz52 deleted the fe/feat/1026-ErrorSuspenseContainer branch January 5, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] ErrorSuspenseContainer 에 Suspense fallback 받을 수 있도록 한다.
4 participants