-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] 리뷰미 2.0.6 배포 #1008
Merged
[Release] 리뷰미 2.0.6 배포 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: 2차 정렬 기준 추가 * refactor: 2차 정렬 기준 추가
* refactor: 타입에 대한 분기를 answerMapper 안에서 처리할 수 있도록 * refactor: 사용하지 않는 코드 제거 * refactor: 하나의 테스트에 한가지를 테스트하도록 * refactor: 추상화를 더욱 활용하도록 * style: 개행 통일 * refactor: getQuestionType 없애고 바로 supports를 사용하도록 * refactor: 다른 유형의 답변이 동시에 입력되는지에 대한 검증 삭제 * refactor: 함수 이름 변경 * style: 띄어쓰기 추가 * refactor: 접근제한자 변경 * refactor: 접근제한자 변경 - 팀의 컨벤션을 위해 & 유지보수 편한 코드를 위해 접근 제한자를 public & private 으로 통일 * refactor: AnswerMapper 변경 - abstract class -> interface * fix: 컴파일 에러 해결 - abstract class -> interface 변환 하면서 extends -> implements 변경되지 않은 부분 변경
* refactor: request limit 코드 제거 * refactor: 로컬, 테스트의 request limit 변수 제거
- Related to 1b6ee74
- 오라클 러너를 사용하도록 변경
donghoony
requested review from
Kimprodp,
nayonsoso,
skylar1220,
chysis,
BadaHertz52,
soosoo22 and
ImxYJL
as code owners
December 15, 2024 07:17
nayonsoso
approved these changes
Dec 15, 2024
skylar1220
approved these changes
Dec 15, 2024
Deploying 2024-review-me-release with Cloudflare Pages
|
Deploying 2024-review-me-develop with Cloudflare Pages
|
BadaHertz52
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀🚀🚀
Kimprodp
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
백엔드 배포만을 포함합니다.
인프라 마이그레이션을 마무리합니다. 배포 서버에서 Redis를 제거합니다.
이외 자잘한 버그를 수정하고 개선했어요.