β¨ π add alert message when form need to be filled #365
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- show "Please fill the form" when the "MAKE RECIPE STEP" button is clicked while edittext is empty
android/app/src/main/java/net/pengcook/android/presentation/making/RecipeMakingFragment.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/java/net/pengcook/android/presentation/making/RecipeMakingViewModel.kt
Outdated
Show resolved
Hide resolved
| @BindingAdapter("bind:content", "bind:visibleCondition") | ||
| fun setVisibility( | ||
| view: View, | ||
| content: String?, | ||
| visibleCondition: Boolean, | ||
| ) { |
There was a problem hiding this comment.
contentμ visibleCondition λ κ°λ₯Ό λ°μ λ€μ κ°μμ±μ νλ¨νλ λ°μΈλ© μ΄λν°μ λ‘μ§μ΄ λκ° λΆμμ°μ€λ¬μ보μ
λλ€.
visibleConditionμ΄λΌλ 맀κ°λ³μμ μ΄λ¦μ μ μ ν λ€μ΄λ°μΌλ‘ λ°κΎΈκ±°λ, λ°μΈλ© μ΄λν° ν¨μκ° κ°μμ±μ μ€μ€λ‘ νλ¨ν μ μλλ‘ νλμ 맀κ°λ³μλ§ λ°μμ€λ κ²μ΄ λ μ’μ보μ
λλ€!
There was a problem hiding this comment.
xmlμμμ μ‘°κ±΄λ¬Έμ΄ μ‘°κΈ κΈΈμ΄μ§κΈ΄ νκ² μ§λ§ κΈ°μ‘΄μ bind:visibility ν¨μλ₯Ό νμ©ν΄μ ν΄κ²°ν΄λμμ΅λλ€.
| fun setTimeVisibility( | ||
| view: View, | ||
| hour: String?, | ||
| minute: String?, | ||
| second: String?, | ||
| visibleCondition: Boolean, | ||
| ) { |
There was a problem hiding this comment.
μμ κ°μ μ견μ λλ€!!
| private val _isButtonClicked: MutableLiveData<Boolean> = MutableLiveData(false) | ||
| val isButtonClicked: LiveData<Boolean> | ||
| get() = _isButtonClicked |
There was a problem hiding this comment.
μ΄λ²€νΈμΈ λ§νΌ, ν λ² μλΉλλ©΄ λΌμ΄λΈ λ°μ΄ν° λ΄λΆ κ°μ λ μ΄μ μ¬μ©νμ§ λͺ»νλλ‘ μ‘°μΉνλ κ²μ΄ μ’μ보μ λλ€!
There was a problem hiding this comment.
μ΄λ²€νΈλΌλ©΄ visibilityλ₯Ό μ§μκ°λ₯νκ² νκΈ° μ΄λ €μΈκ² κ°μλ° νΉμ μ견μ λ μμΈν μ€λͺ ν΄μ£Όμ€ μ μμκΉμ?
There was a problem hiding this comment.
ν΄λΉ νμΌμ λΉλ‘―ν λͺ¨λ form κ΄λ ¨ νμΌλ€μ λν μ견μ λλ€!
κ°μΈμ μΌλ‘ μκ°νλ λ°λ κΈ°μ‘΄μ item_form_~~ νμΌμ κ·Έλλ‘ λκ³ ,
λ€μκ³Ό κ°μ΄ λ³λμ νμΌλ‘ formμ λν μλ΄λ₯Ό λλ λ μ΄μμμ λ°λ‘ λ§λλ κ²μ΄ λ μ’λ€κ³ μκ°νμ΅λλ€.
μλκ° κ·Έ μμκ° λ μ μκ² λ€μ!
// item_form_text_with_notification(?)
<layout>
<data>
<variable
name="content"
type="String" />
<variable
name="visibleCondition"
type="Boolean" />
</data>
<androidx.constraintlayout.widget.ConstraintLayout>
<include layout="@layout/item_form_text" content="@{content}" />
<!-- κ²½κ³ ν
μ€νΈλ·° -->
<TextView visibility="@{쑰건}"/>
</androidx.constraintlayout.widget.ConstraintLayout>
</layout>
κ°μ₯ ν° μ΄μ λ, μμμ μ νμ λμ§ μλ formμ΄ μΈμ λ μ‘΄μ¬ν μ μλ€λ κ°λ₯μ±μ΄ μμ κ²μ΄λΌ μκ°νμκΈ° λλ¬Έμ λλ€.
λ¬Όλ‘ visible conditionμ falseκ°μ 보λ΄λ κ²μ΄ λ°©λ²μ΄ λκ² μ§λ§, κ°μΈμ μΌλ‘λ μ¬μ©νμ§λ μμ κ°μ 보λ΄λ κ²μ μ νΈνμ§λ μμμμ.
ν΄λΉ μ¬νμ μκ°μ μΈ μ¬μ κ° λμ λ€λ©΄ λ°μ λΆνλλ¦¬κ² μ΅λλ€!
Original issue description
closes #364