사용자 인증에서 카카오 계정 전환 엣지 케이스 수정 #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ay-eonii
requested changes
Oct 17, 2024
|
|
||
| @Component | ||
| public class AccessTokenProvider { | ||
|
|
||
| public static final String MEMBER_ID_CLAIM_KEY = "id"; | ||
| public static final String SOCIAL_LOGIN_ID_CLAIM_KEY = "socialLoginId"; | ||
| private static final String OAUTH_TYPE = "oauthType"; |
There was a problem hiding this comment.
위에 두 개 상수 지금보니까 public 이네욤
| Claims claims = getPayload(token); | ||
|
|
||
| if (claims.getExpiration().before(new Date())) { | ||
| throw new AuthException(HttpStatus.UNAUTHORIZED, AuthErrorMessage.UNAUTHORIZED); | ||
| } | ||
| if (claims.get(OAUTH_TYPE) == OauthType.KAKAO.toString()) { |
There was a problem hiding this comment.
string을 == 로 비교하면 항상 다르지 않나용? 그리고 string으로 비교하는 이유가 있나요?
ksk0605
approved these changes
Oct 17, 2024
Comment on lines
+62
to
67
| public void validateToken(String token) { | ||
| Claims claims = getPayload(token); | ||
|
|
||
| if (claims.getExpiration().before(new Date())) { | ||
| throw new AuthException(HttpStatus.UNAUTHORIZED, AuthErrorMessage.UNAUTHORIZED); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
사용자 인증에서 카카오 계정 전환 엣지 케이스 수정
이슈 ID는 무엇인가요?
설명
현재 카카오 계정 전환 플로우는 다음과 같습니다.
만약 사용자가 카카오 로그인만 진행 후 밖으로 나온다면
accessToken 을 가지고 있는 상태가 됨
이를 처리하기 위해 accessToken 에 OauthType을 추가한다.
인터셉터에서 OauthType이 Kakao 인 토큰을 가지고 접근하려고 하면 예외를 발생
질문 혹은 공유 사항 (Optional)