다락방 멤버 조회 권한 삭제 #586
Merged
다락방 멤버 조회 권한 삭제 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ay-eonii
requested review from
Mingyum-Kim,
ksk0605,
hoyeonyy and
pricelees
pricelees
approved these changes
Oct 3, 2024
| @@ -35,23 +33,6 @@ class DarakbangMemberServiceTest { | |||
| @Autowired | |||
| private DarakbangMemberService darakbangMemberService; | |||
|
|
|||
| @DisplayName("다락방 멤버 조회 테스트") | |||
There was a problem hiding this comment.
당연하게 이루어지는거긴 하지만~ 관리자가 아니면 실패하는 테스트를 지웠다면 관리자가 아니어도 조회할 수 있는 테스트를 추가할 수도 있겠네요
Mingyum-Kim
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
다락방 멤버 조회 권한을 삭제하여
모든 다락방멤버가 다락방 멤버 목록을 조회 가능하도록 변경했습니다.
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)