소셜 로그인한 회원 탈퇴 기능 구현 #582
Merged
소셜 로그인한 회원 탈퇴 기능 구현 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingyum-Kim
requested review from
ksk0605,
ay-eonii,
hoyeonyy and
pricelees
ay-eonii
approved these changes
Sep 27, 2024
ay-eonii
reviewed
Sep 27, 2024
| @@ -31,4 +32,10 @@ public ResponseEntity<RestResponse<MemberFindResponse>> findMyInfo( | |||
|
|
|||
| return ResponseEntity.ok().body(new RestResponse<>(memberFindResponse)); | |||
| } | |||
|
|
|||
| @DeleteMapping("/delete") | |||
| public ResponseEntity<Void> removeMember(@LoginDarakbangMember DarakbangMember member) { | |||
There was a problem hiding this comment.
이 부분 나중에 헷갈리더라구요 ㅠㅠ
Suggested change
| public ResponseEntity<Void> removeMember(@LoginDarakbangMember DarakbangMember member) { | |
| public ResponseEntity<Void> removeMember(@LoginDarakbangMember DarakbangMember darakbangMember) { |
pricelees
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
이슈 ID는 무엇인가요?
설명
회원 탈퇴는 회원 정보를 테이블에서 제거하는 것으로 구현합니다.
AccessToken이 있더라도 회원 테이블에서 조회가 불가능하다면 다시 로그인할 수 없습니다.
질문 혹은 공유 사항 (Optional)
만약 회원 탈퇴 후 재로그인한다면 현재 구현으로는
이메일 수집 동의처럼 체크하는 화면이 뜨지 않을 것입니다.이를 해결하기 위해서는 애플 서버에 토큰을 무효화하는 API를 보내야하는데, 우선은 우리 서버 단에서만 회원 탈퇴 시키는 것으로 구현하겠습니다.