모임 도메인 코드 리팩터링 #542
Merged
모임 도메인 코드 리팩터링 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pricelees
requested review from
Mingyum-Kim,
ksk0605,
ay-eonii and
hoyeonyy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
모임 도메인에 있는 코드를 리팩터링 했습니다.
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)
저희는 이번 리팩터링을 진행할 때 아래 방향으로 진행했어요.
Service에서 Validator를 사용하지 않는 방법으로 구현했어요. 검증은 Finder나 Writer의 역할이라고 생각했습니다.
객체는 service에서 조회한다. Writer에는
long id가 아닌 객체를 넣는다.추가적으로, implement에 있는 코드간의 의존성에 대해 고민해봐야 할 것 같아요. (예를 들어 Finder, Writer에서 Validator를 쓴다. Validator에서는 Finder, Writer를 쓰지 않는다와 같은..)
일단 간단한 개요만 적어둘 테니(나아연 아님), 자세한 얘기는 댓글에서 하면 좋을 것 같습니다.