Auth, Notification 도메인 리팩토링 #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ay-eonii
approved these changes
Sep 10, 2024
Comment on lines
+16
to
+22
| public List<String> findAllByRecipientId(long recipientId) { | ||
| return fcmTokenRepository.findAllTokenByMemberId(recipientId); | ||
| } | ||
|
|
||
| public List<String> findAllByRecipients(List<Long> recipients) { | ||
| return fcmTokenRepository.findAllTokenByMemberIds(recipients); | ||
| } |
There was a problem hiding this comment.
이 부분은 일급컬렉션으로 만들지 않아도 될까요??
| memberNotifications | ||
| .stream() | ||
| .map(MemberNotification::getMoudaNotification) | ||
| .map(NotificationFindAllResponse::from) |
Mingyum-Kim
approved these changes
Sep 10, 2024
| Member newMember = Member.builder() | ||
| .kakaoId(kakaoId) | ||
| .build(); | ||
| memberWriter.append(newMember); |
There was a problem hiding this comment.
save 대신에 append 라는 메서드명을 사용한 이유가 뭘까요?
hoyeonyy
approved these changes
Sep 10, 2024
|
|
||
| private final KakaoOauthClient kakaoOauthClient; | ||
|
|
||
| // TODO : 단위 테스트 작성 -> 외부 API는 어떻게 테스트하는 것이 좋은가? 해야하는가? |
hoyeonyy
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
Auth, Notification 서비스의 복잡성을 개선하기 위해 Implement layer 를 도입하여 리팩토링
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)