불필요한 정보 로깅 제외 및 원활한 스웨거 테스트를 위한 설정 #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pricelees
approved these changes
Sep 5, 2024
Comment on lines
76
to
79
| public LoginResponse basicLogin() { | ||
| Member member = memberRepository.findById(1L) | ||
| .orElse(new Member()); | ||
| return new LoginResponse(jwtProvider.createToken(member)); |
There was a problem hiding this comment.
1번 아이디로 멤버를 조회하면 개발(배포) 서버에서는 기존 DB에 저장된 회원이 불러와질수도 있는데, 차라리 아무거나 저장을 하고 불러오는건 어떤지요..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
이슈 ID는 무엇인가요?
설명
로깅
기존 서버의 로깅의 문제점
두 가지 부분을 제외하였어요!
현재는 요렇게 로깅 됩니다.
스웨거 테스트를 위한 설정
질문 혹은 공유 사항 (Optional)