모임 상태 변경 기능 구현 #177
Merged
모임 상태 변경 기능 구현 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ay-eonii
approved these changes
Aug 2, 2024
|
|
||
| @Override | ||
| @DeleteMapping | ||
| public ResponseEntity<Void> cancelChamyo(@Valid @RequestBody ChamyoCancelRequest request, Member member) { |
There was a problem hiding this comment.
모임 취소의 경우 /v1/moim/{moimId}/cancel를 사용중인데, 통일해서 참여 취소도 /v1/chamyo/{chamyoId}/cancel 어떤가요?
There was a problem hiding this comment.
모임 취소의 경우
/v1/moim/{moimId}/cancel를 사용중인데, 통일해서 참여 취소도/v1/chamyo/{chamyoId}/cancel어떤가요?
미참여자는 chamyoId가 없기에, 결과적으로는 moimId가 필요합니다! /v1/chamyo/{moimId} 으로 쓰기엔 애매해서 moimId는 바디에 담게 되었어요~
Mingyum-Kim
approved these changes
Aug 2, 2024
| import jakarta.validation.constraints.Positive; | ||
|
|
||
| public record ChamyoCancelRequest( | ||
| @NotNull @Positive |
Comment on lines
+28
to
+29
| MOIM_CANCELED("이미 취소된 모임이에요."), | ||
| ALREADY_COMPLETED("이미 모집 완료된 모임이에요."), |
There was a problem hiding this comment.
밑에거랑 맞추어서 MOIM_ALREADY_CANCLED로 하는 건 어떤지요 👍
There was a problem hiding this comment.
밑에거랑 맞추어서
MOIM_ALREADY_CANCLED로 하는 건 어떤지요 👍
메시지는 일단 케이스별로 때려 박은거라 전체적으로 다듬어야 할 필요는 있어~ 기능 구현 다 끝나고 같이 정리해보자!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
모임 상태 변경및 참여 취소 기능 추가
이슈 ID는 무엇인가요?
설명
질문 혹은 공유 사항 (Optional)
금요일에 기능을 합치는데 지장이 없도록 최대한 빠르게 구현하였습니다. 짧은 시간 안에 구현하려는 탓에 사소하게 놓치거나 빠진 부분이 있을 것 같아요.
몇몇 부분은 전체 기능이 완료되고 한 번에 수정하는게 나은 것 같더라구요. 그래도 혹시 모르니 빠진 부분에 대해서는 의견 남겨주시면 땡큐!