-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] 행사 비밀번호 암호화 추가 #429
Merged
Merged
[BE] 행사 비밀번호 암호화 추가 #429
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
server/src/main/java/server/haengdong/domain/event/Password.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
package server.haengdong.domain.event; | ||
|
||
import jakarta.persistence.Embeddable; | ||
import java.security.MessageDigest; | ||
import java.security.NoSuchAlgorithmException; | ||
import java.util.Base64; | ||
import java.util.regex.Matcher; | ||
import java.util.regex.Pattern; | ||
import lombok.AccessLevel; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
import server.haengdong.exception.HaengdongErrorCode; | ||
import server.haengdong.exception.HaengdongException; | ||
|
||
@NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
@Getter | ||
@Embeddable | ||
public class Password { | ||
|
||
public static final int PASSWORD_LENGTH = 4; | ||
private static final Pattern PASSWORD_PATTERN = Pattern.compile(String.format("^\\d{%d}$", PASSWORD_LENGTH)); | ||
private static final String HASH_ALGORITHM = "SHA-256"; | ||
|
||
private String value; | ||
|
||
public Password(String password) { | ||
validatePassword(password); | ||
this.value = encode(password); | ||
} | ||
|
||
private void validatePassword(String password) { | ||
Matcher matcher = PASSWORD_PATTERN.matcher(password); | ||
if (!matcher.matches()) { | ||
throw new HaengdongException(HaengdongErrorCode.EVENT_PASSWORD_FORMAT_INVALID); | ||
} | ||
} | ||
|
||
private String encode(String rawPassword) { | ||
try { | ||
MessageDigest digest = MessageDigest.getInstance(HASH_ALGORITHM); | ||
byte[] hashedPassword = digest.digest(rawPassword.getBytes()); | ||
return Base64.getEncoder().encodeToString(hashedPassword); | ||
} catch (NoSuchAlgorithmException e) { | ||
throw new IllegalArgumentException("해시 알고리즘이 존재하지 않습니다."); | ||
} | ||
} | ||
|
||
public boolean matches(String rawPassword) { | ||
String hashedPassword = encode(rawPassword); | ||
return value.equals(hashedPassword); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
server/src/test/java/server/haengdong/domain/event/PasswordTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package server.haengdong.domain.event; | ||
|
||
import static org.assertj.core.api.Assertions.assertThatCode; | ||
|
||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.provider.ValueSource; | ||
import server.haengdong.exception.HaengdongException; | ||
|
||
class PasswordTest { | ||
|
||
@DisplayName("비밀번호는 4자리 숫자 입니다.") | ||
@ParameterizedTest | ||
@ValueSource(strings = {"1", "12", "123", "12345", "adgd"}) | ||
void validatePassword(String rawPassword) { | ||
assertThatCode(() -> new Password(rawPassword)) | ||
.isInstanceOf(HaengdongException.class); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c: displayname이 똑같은데 같은 테스트인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
동일한 메서드에 대한 테스트라서 따로 이름을 설정하지 않았습니다!