Skip to content

Commit

Permalink
fix: 잘못된 요청값 수정 (#566)
Browse files Browse the repository at this point in the history
Co-authored-by: youngsu5582 <[email protected]>
  • Loading branch information
github-actions[bot] and youngsu5582 authored Oct 12, 2024
1 parent b518792 commit 2ff3a98
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import corea.auth.annotation.LoginMember;
import corea.auth.domain.AuthInfo;
import corea.participation.dto.ParticipationHttpRequest;
import corea.participation.dto.ParticipationRequest;
import corea.participation.service.ParticipationService;
import lombok.RequiredArgsConstructor;
Expand All @@ -20,8 +21,8 @@ public class ParticipationController implements ParticipationControllerSpecifica
public ResponseEntity<Void> participate(@PathVariable long id,
@LoginMember AuthInfo authInfo,
@RequestParam(value = "role", defaultValue = "both") String role,
@RequestBody int matchingSize) {
participationService.participate(new ParticipationRequest(id, authInfo.getId(), role, matchingSize));
@RequestBody ParticipationHttpRequest participationHttpRequest) {
participationService.participate(new ParticipationRequest(id, authInfo.getId(), role, participationHttpRequest.matchingSize()));
return ResponseEntity.ok()
.build();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import corea.exception.ExceptionType;
import corea.exception.ExceptionTypeGroup;
import corea.global.annotation.ApiErrorResponses;
import corea.participation.dto.ParticipationHttpRequest;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
Expand Down Expand Up @@ -31,7 +32,7 @@ ResponseEntity<Void> participate(
String role,

@Parameter(description = "참여자가 원하는 매칭 인원 수")
int matchingSize);
ParticipationHttpRequest matchingSize);

@Operation(summary = "방 참여를 취소합니다.",
description = "참여 취소를 원하는 방 상세 페이지에 위치한 취소 버튼을 누르면 참여를 취소할 수 있습니다. <br>" +
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package corea.participation.dto;

import io.swagger.v3.oas.annotations.media.Schema;

public record ParticipationHttpRequest(
@Schema(description = "참여자가 원하는 매칭 인원 수", example = "3")
int matchingSize) {
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import corea.fixture.RoomFixture;
import corea.member.domain.Member;
import corea.member.repository.MemberRepository;
import corea.participation.dto.ParticipationHttpRequest;
import corea.room.domain.Room;
import corea.room.repository.RoomRepository;
import io.restassured.RestAssured;
Expand Down Expand Up @@ -35,7 +36,7 @@ void participate() {
String token = tokenService.createAccessToken(member);

RestAssured.given().auth().oauth2(token)
.body(2)
.body(new ParticipationHttpRequest(2))
.contentType(ContentType.JSON)
.when().post("/participate/" + room.getId())
.then().log().all()
Expand Down

0 comments on commit 2ff3a98

Please sign in to comment.