[BE] 페어룸에 깃허브 ID로 페어 추가 API #810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into BE/feature/#776-github
reddevilmidzy
commented
Oct 16, 2024
Comment on lines
+190
to
+208
| @Test | ||
| @DisplayName("user id로 페어를 등록한다.") | ||
| void add_pair() { | ||
| //given | ||
| final String userId = "redddy"; | ||
| final Member member = Member.builder() | ||
| .userId(userId) | ||
| .accessToken("access") | ||
| .loginId("login") | ||
| .username("username") | ||
| .profileImage("some image") | ||
| .build(); | ||
|
|
||
| final String loginToken = jwtProvider.sign(member.getUserId()); | ||
| memberRepository.save(member); | ||
|
|
||
| final PairRoomCreateRequest pairRoomCreateRequest = new PairRoomCreateRequest("레디", "프람", 1000L, 100L, | ||
| "https://missionUrl.xxx"); | ||
|
|
There was a problem hiding this comment.
테스트의 사이즈가 굉장히 커졌는데 고민입니다...
There was a problem hiding this comment.
멤버 만들기나 페어룸 만들기 같은 부분이라도 private으로 빼는게 최선일까요
There was a problem hiding this comment.
저도 잉크가 말한 것처럼 자주 사용되는
final PairRoomCreateResponse createPairRoomResponse = RestAssured
.given()
.cookie(SIGN_IN_COOKIE_NAME, pairRoomCreatorToken)
.contentType(MediaType.APPLICATION_JSON_VALUE)
.accept(MediaType.APPLICATION_JSON_VALUE)
.body(pairRoomCreateRequest)
.when()
.post("/api/pair-room")
.then()
.extract()
.as(PairRoomCreateResponse.class);요런 친구들을 private 메서드로 분리해서 사용하는 방법이 떠오르네요!
yechop
approved these changes
Oct 17, 2024
|
|
||
| @Schema(description = "페어 추가 요청 바디") | ||
| public record PairUpdateRequest( | ||
|
|
Comment on lines
+190
to
+208
| @Test | ||
| @DisplayName("user id로 페어를 등록한다.") | ||
| void add_pair() { | ||
| //given | ||
| final String userId = "redddy"; | ||
| final Member member = Member.builder() | ||
| .userId(userId) | ||
| .accessToken("access") | ||
| .loginId("login") | ||
| .username("username") | ||
| .profileImage("some image") | ||
| .build(); | ||
|
|
||
| final String loginToken = jwtProvider.sign(member.getUserId()); | ||
| memberRepository.save(member); | ||
|
|
||
| final PairRoomCreateRequest pairRoomCreateRequest = new PairRoomCreateRequest("레디", "프람", 1000L, 100L, | ||
| "https://missionUrl.xxx"); | ||
|
|
There was a problem hiding this comment.
멤버 만들기나 페어룸 만들기 같은 부분이라도 private으로 빼는게 최선일까요
JiHyeonL
approved these changes
Oct 18, 2024
Comment on lines
+190
to
+208
| @Test | ||
| @DisplayName("user id로 페어를 등록한다.") | ||
| void add_pair() { | ||
| //given | ||
| final String userId = "redddy"; | ||
| final Member member = Member.builder() | ||
| .userId(userId) | ||
| .accessToken("access") | ||
| .loginId("login") | ||
| .username("username") | ||
| .profileImage("some image") | ||
| .build(); | ||
|
|
||
| final String loginToken = jwtProvider.sign(member.getUserId()); | ||
| memberRepository.save(member); | ||
|
|
||
| final PairRoomCreateRequest pairRoomCreateRequest = new PairRoomCreateRequest("레디", "프람", 1000L, 100L, | ||
| "https://missionUrl.xxx"); | ||
|
|
There was a problem hiding this comment.
저도 잉크가 말한 것처럼 자주 사용되는
final PairRoomCreateResponse createPairRoomResponse = RestAssured
.given()
.cookie(SIGN_IN_COOKIE_NAME, pairRoomCreatorToken)
.contentType(MediaType.APPLICATION_JSON_VALUE)
.accept(MediaType.APPLICATION_JSON_VALUE)
.body(pairRoomCreateRequest)
.when()
.post("/api/pair-room")
.then()
.extract()
.as(PairRoomCreateResponse.class);요런 친구들을 private 메서드로 분리해서 사용하는 방법이 떠오르네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
구현한 기능
상세 설명