Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

에러 핸들링을 위한 컴포넌트 추가 및 적용 #568

Merged
merged 17 commits into from
Oct 11, 2023
Merged

에러 핸들링을 위한 컴포넌트 추가 및 적용 #568

merged 17 commits into from
Oct 11, 2023

Conversation

solo5star
Copy link
Member

see #540

solo5star and others added 17 commits October 6, 2023 21:20
@solo5star @jeongwusi @geuntaek1013
feat: 에러 정의 (AppError, NetworkError)
5fcdad5 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
feat: ErrorPage에서 AppError 혹은 Error 여부에 따라 메세지 표시 분기 처리
fa83f97 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
feat: NotFoundPage에서 AppError를 throw하도록 수정
73bcefc 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
fix: 연속으로 Toast를 띄울 때 잘 띄워지지 않는 오류 수정
d5629b4 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
feat: ErrorBoundary와 QueryErrorBoundary 구현
ab62224 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
feat: useSilentLink 구현
637fea6 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
feat: ErrorRetryPrompt 구현 및 적용
e592dee 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star @jeongwusi @geuntaek1013
feat: 에러 처리 router에 적용
ce26068 
Co-authored-by: jeongwusi <[email protected]>
Co-authored-by: geuntaek1013 <[email protected]>
@solo5star
feat: CafeDetailBottomSheet에 QueryErrorBoundary 적용
8f39e61
@solo5star
style: 컴포넌트 코드 순서 변경
34534f8
@solo5star
feat: ErrorBoundary, QueryErrorBoundary 몇몇 props 추가
8f8bd53 
* caught, FallbackComponent 추가
* fallbackRender에서 error도 주입
@solo5star
fix: ErrorRetryPrompt가 대부분의 box에서 잘 표시되도록 수정
9871b03
@solo5star
feat: 메세지 수정
98acc12
@solo5star
docs: AppError 클래스에 JSDoc 추가
13558c7
@solo5star
docs: NetworkError에 JSDoc 추가
bea286a
@solo5star
feat: APIError 추가 및 적용
15f1074
@solo5star
feat: query retry off
c5bbb90
@solo5star solo5star added 카테고리:기능🛠️ 만들어줘잉 FE 될 때까지 한다잉 작업:몹 몹 프로그래밍으로 진행이 필요합니다 우선순위:🟡보통 급하진 않지만, 필요한 작업입니다. 카테고리:리팩토링🪚 리팩토링입니다. labels Oct 11, 2023
@solo5star solo5star merged commit 8564562 into main Oct 11, 2023
0 of 2 checks passed
@solo5star solo5star deleted the feat/540-improved-error-handling branch October 11, 2023 09:36
@solo5star solo5star linked an issue Oct 11, 2023 that may be closed by this pull request
세분화된 에러 핸들링 #540
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongwusi jeongwusi Awaiting requested review from jeongwusi jeongwusi is a code owner

@geuntaek1013 geuntaek1013 Awaiting requested review from geuntaek1013 geuntaek1013 is a code owner

Assignees

@solo5star solo5star

@geuntaek1013 geuntaek1013

@jeongwusi jeongwusi

Labels
FE 될 때까지 한다잉 우선순위:🟡보통 급하진 않지만, 필요한 작업입니다. 작업:몹 몹 프로그래밍으로 진행이 필요합니다 카테고리:기능🛠️ 만들어줘잉 카테고리:리팩토링🪚 리팩토링입니다.
Projects
2023-yozm-cafe
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

세분화된 에러 핸들링
3 participants
@solo5star @geuntaek1013 @jeongwusi