Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

카페 이미지 Outer Join -> Inner Join (카페 이미지 최소 1개 이상 포함시키기) #492

Merged
merged 39 commits into from
Sep 26, 2023

Conversation

nuyh99
Copy link
Collaborator

@nuyh99 nuyh99 commented Sep 26, 2023

#️⃣ 연관된 이슈

📝 작업 내용

  • 테스트 환경 설정에서 빠진 batch size 추가(팀시티에도 없더라구요...)
  • CafeRankGenerator 제거(Pageableoffset 사용)
  • cafe.images.url 조인할 때 outer join -> inner join으로 변경 (패치 조인 가능)
    • 이미지 최소 1개 이상 포함하도록 검증 로직 추가

비고

  • 여러 머지 커밋들과 컨플릭트 해결한다고 추가 커밋이 많이 들어왔네요

hum02 and others added 30 commits September 8, 2023 17:10
@nuyh99 nuyh99 added the BE 개발은 백이징 label Sep 26, 2023
@nuyh99 nuyh99 requested a review from donghae-kim as a code owner September 26, 2023 12:18
@nuyh99 nuyh99 self-assigned this Sep 26, 2023
@nuyh99 nuyh99 changed the title 카페 이미지 Outer Join -> Inner Join 카페 이미지 Outer Join -> Inner Join (카페 이미지 최소 1개 이상 포함시키기) Sep 26, 2023
@nuyh99 nuyh99 merged commit 3237cce into main Sep 26, 2023
@nuyh99 nuyh99 deleted the feat/467-inner-join branch September 26, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 개발은 백이징
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

카페가 이미지를 최소 1개 이상 포함하도록 한다.
5 participants