검색 기능 구현 #490
Merged
검색 기능 구현 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cafe into feat/489-search
Closed
4 tasks
jeongwusi
requested changes
Sep 29, 2023
| if (Object.keys(sanitizedSearchParams).length === 0) { | ||
| return Promise.resolve([]); | ||
| } | ||
| return this.fetchJson<SearchedCafe[]>(`/cafes/search?${new URLSearchParams(sanitizedSearchParams).toString()}`); |
There was a problem hiding this comment.
new URLSearchParams에 대한 설명 잘 들었습니다~~
|
|
||
| const [isDetailEnabled, setIsDetailEnabled] = useState(false); | ||
|
|
||
| const query = useDeferredValue(isDetailEnabled ? { searchName, searchAddress, searchMenu } : { searchName }); |
There was a problem hiding this comment.
오홍...! useDeferredValue()를 이용하셨군요 👍🏻👍🏻👍🏻
There was a problem hiding this comment.
네 맞습니다~! useDeferredValue를 사용하면 fallback을 보여주는 대신 이전의 렌더를 보여주기 때문에 끊김이 없는 것처럼 보여 사용자 경험에 좋은 영향을 줄 수 있습니다
| font-size: ${({ theme }) => theme.fontSize['2xl']}; | ||
| `; | ||
|
|
||
| const FormGroup = styled.fieldset` |
| if (Object.keys(sanitizedSearchParams).length === 0) { | ||
| return Promise.resolve([]); | ||
| } | ||
| return this.fetchJson<SearchedCafe[]>(`/cafes/search?${new URLSearchParams(sanitizedSearchParams).toString()}`); |
There was a problem hiding this comment.
근데 메서드 POST인데 { method: 'POST' } 이거 필요 없나용?
There was a problem hiding this comment.
어떤게 POST라는 걸까용? 서버 측에선 GET으로 구현되어 있기 때문에 GET 을 사용하였습니당
|
|
||
| return useSuspenseQuery<SearchedCafe[]>({ | ||
| queryKey: ['searchCafes', query], | ||
| retry: false, |
There was a problem hiding this comment.
검색 결과 조회는 타이핑마다 일어나기 때문에 빈번히 요청합니다. 여기서 이전 타이핑의 조회 결과는 필요없기 때문에 굳이 retry로 가져올 필요는 없기 때문입니다~!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
close #489
📝 작업 내용
💬 리뷰 요구사항