[refactor] N + 1 문제를 개선한다. #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devHudi
approved these changes
Oct 6, 2022
저희는 페이지네이션을 할 때 OneToMany를 사용하지 않아서 전혀 지장이 없습니다. - 매트 (1997. 09. 29 ~ ) |
gudonghee2000
approved these changes
Oct 6, 2022
Comment on lines
+16
to
+18
| @EntityGraph(attributePaths = {"category", "category.member"}) | ||
| List<CategoryRole> findByMemberId(final Long memberId); | ||
|
|
There was a problem hiding this comment.
한번에 fetch join 해오는군요!!
| @@ -26,14 +23,11 @@ public ExternalCalendarService(final OAuthClient oAuthClient, final ExternalCale | |||
| } | |||
|
|
|||
| public ExternalCalendarsResponse findByMemberId(final Long memberId) { | |||
| OAuthToken oAuthToken = oAuthTokenRepository.findByMemberId(memberId) | |||
| .orElseThrow(NoSuchOAuthTokenException::new); | |||
| OAuthToken oAuthToken = oAuthTokenRepository.getByMemberId(memberId); | |||
| @@ -12,10 +13,10 @@ public interface SubscriptionRepository extends JpaRepository<Subscription, Long | |||
|
|
|||
| boolean existsByIdAndMemberId(final Long id, final Long memberId); | |||
|
|
|||
| // TODO: N + 1 개선 예정 | |||
| // TODO: @EntityGraph(attributePaths = {"category", "category.member"}) | |||
| @EntityGraph(attributePaths = {"category", "category.member"}) | |||
Comment on lines
-207
to
-218
| @DisplayName("멤버와 카테고리 역할 목록으로 카테고리를 조회한다.") | ||
| @Test | ||
| void 멤버와_카테고리_역할_목록으로_카테고리를_조회한다() { | ||
| // given | ||
| Member 관리자 = memberRepository.save(관리자()); | ||
| Member 후디 = memberRepository.save(후디()); | ||
|
|
||
| Category 카테고리1 = categoryRepository.save(공통_일정(관리자)); | ||
| Category 카테고리2 = categoryRepository.save(BE_일정(관리자)); | ||
| Category 카테고리3 = categoryRepository.save(FE_일정(관리자)); | ||
| Category 카테고리4 = categoryRepository.save(매트_아고라(관리자)); | ||
| Category 카테고리5 = categoryRepository.save(후디_JPA_스터디(관리자)); |
There was a problem hiding this comment.
불필요한 테스트 코드가 삭제되었군요🚀🚀
| @@ -113,14 +114,21 @@ public CategoriesWithPageResponse findMyCategories(final Long memberId, final St | |||
|
|
|||
| // 멤버가 ADMIN이 아니어도 일정 추가/제거/수정이 가능하므로, findAdminCategories와 별도의 메소드로 분리해야함 | |||
| public CategoriesResponse findScheduleEditableCategories(final Long memberId) { | |||
| List<CategoryRole> categoryRoles = categoryRoleRepository.findByMemberId(memberId); | |||
There was a problem hiding this comment.
CategoryRepository에 있던 CategoryRole을 통한 데이터 조회 로직이 삭제되었네요!!
Comment on lines
+126
to
+131
|
|
||
| private List<Category> toCategories(final List<CategoryRole> categoryRoles, final Set<CategoryRoleType> roleTypes) { | ||
| return categoryRoles.stream() | ||
| .filter(categoryRole -> roleTypes.contains(categoryRole.getCategoryRoleType())) | ||
| .map(CategoryRole::getCategory) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
a: 저는 변환 로직을 DTO로 옮기는 편이여서 CategoriesResponse에서 해당 변환로직을 가지는건 어떨까해요!
한번 의견만 제시해보았어요😊😊
There was a problem hiding this comment.
이 부분은 항상 고민이네요... 저는 dto가 가벼운 걸 선호해서 일단 유지하겠습니다!
hyeonic
force-pushed
the
feature/718-n+1
branch
from
dce7415
to
6cddc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feat] PR을 등록한다.작업 내용
N + 1 문제를 개선한다.
스크린샷
주의사항
Closes #718