Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] 패키지 순환 참조를 개선한다. #687

Merged

Conversation

hyeonic
Copy link
Collaborator

@hyeonic hyeonic commented Sep 30, 2022

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🌈 알록달록한가요?

작업 내용

코드의 변경이 거의 없습니다. 왜 이렇게 변경하게 되었는지에 대한 과정은 cyclic dependency에 작성해두었습니다!

스크린샷

주의사항

Closes #668

@hyeonic hyeonic added backend 백엔드 refactor 리팩터링 labels Sep 30, 2022
@hyeonic hyeonic self-assigned this Sep 30, 2022
Copy link
Collaborator

@devHudi devHudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

블로그 글 잘 읽었습니다! Subscription 에 대한 의존을 끊고, Category에 의존하도록 개선되었네요. Approve 하겠습니다!

Copy link
Collaborator

@summerlunaa summerlunaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오우 전혀 모르고 있었는데 꼼꼼하게 확인해서 순환참조를 없애주셨군요..! approve 합니다!

@hyeonic hyeonic force-pushed the feature/668-cyclic-dependency branch from 193ff31 to 0c8eb4e Compare October 3, 2022 04:06
@hyeonic hyeonic merged commit 666a6c5 into woowacourse-teams:develop Oct 3, 2022
@hyeonic hyeonic deleted the feature/668-cyclic-dependency branch October 3, 2022 04:10
@hyeonic hyeonic mentioned this pull request Oct 19, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend 백엔드 refactor 리팩터링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants