feat: 사용자는 REST API를 통해서 거래 내역 상세 조회 기능을 사용할 수 있다 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 소유자 인증 부분은 제외하였습니다
- adoc에 테스트와 동일한 경로로 설정했습니다
- 추후 인증 객체 도입 후 작업하도록 TODO 작성했습니다
yudonggeun
reviewed
Aug 18, 2024
Comment on lines
-29
to
-35
| if (!bidHistory.isOwnedBy(member)) { | ||
| throw new UnauthorizedException( | ||
| "해당 거래 내역에 접근 권한이 없는 사용자입니다. 회원ID: " + (member == null ? "없음" : member.getSignInId()), | ||
| ErrorCode.B001); | ||
| } | ||
|
|
There was a problem hiding this comment.
ReceiptController에서도 자신의 거래 내역인지를 확인하는 로직이 없는 것 같아요.
외부의 다른 로그인 사용자가 다른 사람의 거래 내역 id를 알 수 있다면 정보를 노출 시킬 위험이 있어서 제거된 부분의 검증은 구현해야한다고 생각합니다!
There was a problem hiding this comment.
이 부분이 인증 객체로 따로 구현중이라서 인증 부분을 제거했습니다!
| .apply(document("/auctions/post/constant_policy/success", | ||
| .apply(document("auctions/post/constant_policy/success", |
There was a problem hiding this comment.
세심하게 코드 스타일 챙겨주는 습관 부럽네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
변경사항
BidHistoryService의getBidHistoryInfo는 사용자 객체를 인자로 받았습니다REST Docs
dev브랜치에 경로가 제대로 명시되어지지 않은 테스트가 있어 수정했습니다🙋🏻 More
이상한 부분에 신경을 쓰니 작은 업무인데 속도가 너무 느리네요..
더 열심히 하겠슴돠!!! 👍
close #118