Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 판매자는 경매 상품 목록에서 경매 식별자, 원가, 현재 판매가, 총 제고량, 현재 제고량, 시작시간, 종료시간을 확인할 수 있다. #186

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

yudonggeun
Copy link
Contributor

@yudonggeun yudonggeun commented Aug 15, 2024

📄 Summary

  • 구매자 거래 내역 목록 조회 dto (SellerAuctionSimpleInfo) 생성
  • SellerAuctionSimpleInfo Mapper 변환 메서드 구현 및 테스트
  • AuctionRepository#findAllBy 정의
  • AuctionService#getSellerAuctionSimpleInfos구현

🙋🏻 More

close #128

- Mapper#convertToSellerAuctionSimpleInfo 구현
- Mapper#convertToSellerAuctionSimpleInfo 테스트 구현
판매자 경매 상품 목록 조회 SQL 조건 dto
- @param SellerAuctionSearchCondition을 가지는 메서드 정의
- FakeAuctionRepository#findAllBy 구현
@yudonggeun yudonggeun added the FEATURE 새로운 기능 또는 변경 label Aug 15, 2024
@yudonggeun yudonggeun self-assigned this Aug 15, 2024
@yudonggeun yudonggeun requested a review from a team August 15, 2024 09:28
Comment on lines +5 to +16
/**
* 판매자 경매 목록 조회시 사용되는 Auction 정보입니다.
*
* @param id 경매 식별자
* @param title 경매 노출 제목
* @param originPrice 원가
* @param currentPrice 현재 가격
* @param totalStock 총 재고
* @param currentStock 현재 남은 재고
* @param startedAt 시작 시간
* @param finishedAt 종료 시간
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

목록에서 필요한 항목만 잘 정의된 것 같아요 ^_^

Copy link
Member

@chhs2131 chhs2131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저녁반 화이팅~~

@yudonggeun yudonggeun merged commit 2548397 into dev Aug 15, 2024
1 check passed
@yudonggeun yudonggeun deleted the feat/128-issue branch August 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE 새로운 기능 또는 변경
Projects
None yet
2 participants