-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 판매자는 경매 상품 목록에서 경매 식별자, 원가, 현재 판매가, 총 제고량, 현재 제고량, 시작시간, 종료시간을 확인할 수 있다. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mapper#convertToSellerAuctionSimpleInfo 구현 - Mapper#convertToSellerAuctionSimpleInfo 테스트 구현
판매자 경매 상품 목록 조회 SQL 조건 dto
- @param SellerAuctionSearchCondition을 가지는 메서드 정의 - FakeAuctionRepository#findAllBy 구현
chhs2131
reviewed
Aug 15, 2024
Comment on lines
+5
to
+16
/** | ||
* 판매자 경매 목록 조회시 사용되는 Auction 정보입니다. | ||
* | ||
* @param id 경매 식별자 | ||
* @param title 경매 노출 제목 | ||
* @param originPrice 원가 | ||
* @param currentPrice 현재 가격 | ||
* @param totalStock 총 재고 | ||
* @param currentStock 현재 남은 재고 | ||
* @param startedAt 시작 시간 | ||
* @param finishedAt 종료 시간 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
목록에서 필요한 항목만 잘 정의된 것 같아요 ^_^
chhs2131
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저녁반 화이팅~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
close #128