fix(headings): H3 - H6 have same scope as H2 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
mdx-js/mdx-analyzer#483 (comment) Feel free to pick where to discuss this. But I responded there. |
wooorm
approved these changes
Nov 11, 2024
|
Thanks Isaac! Appreciate you solving this, with tests. Most places pull changes in from this repo once in a while. So, depends how long you’ll have to wait for it to get somewhere! |
|
No problem! Glad I could help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes scope assignments detailed in #11. I made sure to regenerate the tmLanguage files as well as adding a new test for headings. Please let me know if there's anything I missed!