-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace builtins
dep w/ builtinModules
#9
Conversation
Ah that has good support, great. Thanks for looking into this! |
"dependencies": { | ||
"builtins": "^5.0.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep this as "dependencies": {},
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It might be the case that a package manager removes this the next time the dependencies are modified via the CLI, though.
Do you have any clue why coverage is decreasing? And if so, on how to fix it? |
I'm pretty sure that the coverage is decreasing because I'm removing code. There's the "project" diff, which goes down extremely slightly: 87.20% (-0.03%) Then there's the "patch" diff, which says "66.66% of diff hit", because 33% of my patch involves code which already isn't covered, see: https://app.codecov.io/gh/wooorm/import-meta-resolve/blob/main/lib/resolve.js |
builtins
dep w/ builtinModules
Thanks, released! |
Fixes #7.
Per the docs, this exists in versions above: v9.3.0, v8.10.0, v6.13.0
So, this should be safe, and eliminates
athe only dependency! 🎉