Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace builtins dep w/ builtinModules #9

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Conversation

jakebailey
Copy link
Contributor

@jakebailey jakebailey commented Aug 14, 2022

Fixes #7.

Per the docs, this exists in versions above: v9.3.0, v8.10.0, v6.13.0

So, this should be safe, and eliminates a the only dependency! 🎉

@wooorm
Copy link
Owner

wooorm commented Aug 14, 2022

Ah that has good support, great. Thanks for looking into this!

Comment on lines -31 to -33
"dependencies": {
"builtins": "^5.0.0"
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep this as "dependencies": {},?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It might be the case that a package manager removes this the next time the dependencies are modified via the CLI, though.

@wooorm
Copy link
Owner

wooorm commented Aug 14, 2022

Do you have any clue why coverage is decreasing? And if so, on how to fix it?

@jakebailey
Copy link
Contributor Author

I'm pretty sure that the coverage is decreasing because I'm removing code.

There's the "project" diff, which goes down extremely slightly: 87.20% (-0.03%)

Then there's the "patch" diff, which says "66.66% of diff hit", because 33% of my patch involves code which already isn't covered, see: https://app.codecov.io/gh/wooorm/import-meta-resolve/blob/main/lib/resolve.js

image

@wooorm wooorm changed the title Use builtinModules instead of builtins dependency Replace builtins dep w/ builtinModules Aug 14, 2022
@wooorm wooorm merged commit 44c01b0 into wooorm:main Aug 14, 2022
@jakebailey jakebailey deleted the builtins branch August 14, 2022 21:19
@wooorm
Copy link
Owner

wooorm commented Aug 14, 2022

Thanks, released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use module.builtinModules instead of builtins dependency
2 participants