Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with loading from ESM, "type": "module", & rollup #1

Closed
btakita opened this issue Jul 21, 2021 · 2 comments
Closed

Issues with loading from ESM, "type": "module", & rollup #1

btakita opened this issue Jul 21, 2021 · 2 comments

Comments

@btakita
Copy link

btakita commented Jul 21, 2021

I ran across an issue with loading this library from an ESM & have since vendorized it with a forked repo & custom build to fix the problem. I'm creating this issue to track the changes. I'll investigate if there is any problem with this package of if it's a problem with a dependency.

builtins is a dependency with a loading issue from ESM. juliangruber/builtins#37

Please keep this issue open until I can provide more detail. Thank you.

@wooorm
Copy link
Owner

wooorm commented Jul 29, 2021

What is the problem? The error you ran into?
I’m guessing you have a problem with Vite and Rollup?
If so: report it there. CJS dependencies are fine in Node ESM!

@btakita
Copy link
Author

btakita commented Jul 31, 2021

I'm able to use:

import * from imr from 'import-meta-resolve'
const { resolve } = imr

so it works as expected, but it's not as convenient for ESM users as CJS users.

@btakita btakita closed this as completed Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants