Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expt 0.4.1 breaks in python 3.10 #24

Closed
vwxyzjn opened this issue Jun 5, 2023 · 2 comments
Closed

expt 0.4.1 breaks in python 3.10 #24

vwxyzjn opened this issue Jun 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@vwxyzjn
Copy link

vwxyzjn commented Jun 5, 2023 •
edited
Loading 

import expt
expt.Experiment("Comparison")

seems to break in python 3.10.

image
vwxyzjn added a commit to openrlbenchmark/openrlbenchmark that referenced this issue Jun 5, 2023
@vwxyzjn
fix python 3.10 type guard
6c3352c 
wookayin/expt#24
vwxyzjn added a commit to openrlbenchmark/openrlbenchmark that referenced this issue Jun 5, 2023
@vwxyzjn
General rliable support (#22)
27851fc 
* Refactor rliable

* plot xlabel

* set a faster default value for bootstrap reps

* Display global steps properly

* use `--rliable` command

* bug fix

* typo

* refactor rliable logic out

* bump poetry version

* remove CI on push

* typo fix

* fix python 3.10 type guard

wookayin/expt#24

* bump version; update docs

* update docs

* Update test.yaml
vwxyzjn added a commit to openrlbenchmark/openrlbenchmark that referenced this issue Jun 7, 2023
@ffelten @vwxyzjn
[WIP] Multi metric support (#23)
b941106 
* Refactor rliable

* plot xlabel

* set a faster default value for bootstrap reps

* Display global steps properly

* WIP - works for multi metric in MORL

* Display titles only on top row, and ylabels only on left column

* Fix issue with dropna removing valid rows

* Update plots and command

* Fix runtime scaling

* use `--rliable` command

* bug fix

* typo

* refactor rliable logic out

* bump poetry version

* remove CI on push

* typo fix

* fix python 3.10 type guard

wookayin/expt#24

* bump version; update docs

* update docs

* Add CI computation

* push changes

* update multi metrics example

* bump version

* bug fix

* by default check empty runs

---------

Co-authored-by: Costa Huang <[email protected]>
@wookayin
Copy link
Owner

wookayin commented Jun 9, 2023

Thanks for the report. Yes, indeed the line

      hypotheses: Iterable[Hypothesis] = None,

is a not typing.

This is no longer a problem in the master branch as have been fixed since 1166a49, but I will backport the fix because people would want a stable version that works.

A workaround would be specifying the argument explicitly: Experiment(name, hypotheses=())

@wookayin wookayin added the bug Something isn't working label Jun 9, 2023
wookayin added a commit that referenced this issue Jun 10, 2023
@wookayin
Fix invalid default arguments to Experiment's constructor (#24)
06075a8 
A recent version of typeguard raises an error when the default argument
for Experiment.__init__(hypotheses=...) is used.

This is a backport patch applied towards v0.4.2; on the master branch
this already has been fixed (see 1166a49).
@wookayin
Copy link
Owner

This is actually a typeguard issue rather than python 3.10. I've released v0.4.2 which contains a backport patch.

wookayin added a commit that referenced this issue Jul 29, 2023
@wookayin
Add a test case for #24.
6baf857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wookayin @vwxyzjn