Improve __repr__ of ConfigReader classes.

wookayin · Aug 12, 2024 · 790b613 · 790b613
1 parent 976b5a2
commit 790b613
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/expt/data_loader.py b/expt/data_loader.py
@@ -657,6 +657,10 @@ def __call__(self, log_dir: LogDir) -> Optional[RunConfig]:
       d = yaml.load(fp, yaml.SafeLoader)
     return d
 
+  def __repr__(self):
+    typ = type(self)
+    return f"<{typ.__module__}.{typ.__qualname__}(config_filename='{self._config_filename}')>"
+
 
 class JsonConfigReader(ConfigReader):
   """Reads config.json from the log directory.
@@ -675,11 +679,24 @@ def __call__(self, log_dir: LogDir) -> Optional[RunConfig]:
       d = json.load(fp)
     return d
 
+  def __repr__(self):
+    typ = type(self)
+    return f"<{typ.__module__}.{typ.__qualname__}(config_filename='{self._config_filename}')>"
+
 
 class ConfigReaderComposite(ConfigReader):
 
   def __init__(self, config_readers: Sequence[ConfigReader]):
-    self._config_readers = config_readers
+    self._config_readers = list(config_readers)
+
+  def __repr__(self):
+    typ = type(self)
+    return "".join([
+        f"<{typ.__module__}.{typ.__qualname__}[",
+        "\n" if self._config_readers else "",
+        *["  " + repr(reader) + ",\n" for reader in self._config_readers],
+        "]>",
+    ])
 
   def __call__(self, log_dir: LogDir) -> Optional[RunConfig]:
     for reader in self._config_readers: