This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Fix execution order of Unity tasks in sub modules #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larusso
force-pushed
the
fix/execution_order_of_unity_tasks_in_submodules
branch
from
da00ea5 to
51a051a
Compare
Description =========== We have a new bug where some unity tasks get executed before the paket unity install tasks had any chance to be executed. This patch is addressing this by making sure that any task of type `wooga.gradle.unity.UnityTask` depends on * `paketUnityInstall` * `paketUnityUnwrapUPMPackages` Changes ======= * ![FIX] execution order of Unity tasks in sub modules
Larusso
force-pushed
the
fix/execution_order_of_unity_tasks_in_submodules
branch
from
51a051a to
594c83a
Compare
pletoss
reviewed
Feb 16, 2023
| @@ -46,6 +46,26 @@ class ReleasePluginIntegrationSpec extends IntegrationSpec { | |||
| createFile("paket.dependencies") | |||
| } | |||
|
|
|||
| def "verify paket unity install is called before any unity task is executed"() { | |||
There was a problem hiding this comment.
nice!
did you happend to TDD-ish this? e.g. did you run this test on the negative case, when this fix wasn't applied yet ?
There was a problem hiding this comment.
Well locally yes. But I don't provide a negative test case here because the feature is not configuratble.
There was a problem hiding this comment.
To make this clearer and saver I should actually call multiple other Unity tasks and define custom ones. To actually proof this.
There was a problem hiding this comment.
I take it as is for now though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a new bug where some unity tasks get executed before the paket unity install tasks had any chance to be executed. This patch is addressing this by making sure that any task of type
wooga.gradle.unity.UnityTaskdepends onpaketUnityInstallpaketUnityUnwrapUPMPackagesChanges