This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Adds the preflight release_stage [ATLAS-645] #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Larusso
suggested changes
Mar 21, 2022
| @@ -440,6 +440,7 @@ class ReleasePluginIntegrationSpec extends IntegrationSpec { | |||
| "final" | false | |||
| "release" | false | |||
| "rc" | true | |||
| "pre" | true | |||
There was a problem hiding this comment.
I thought we call it prefligh everywhere
There was a problem hiding this comment.
I thought pre is one of the possible inputs for the preflight. I guess we should add preflight as well?
I mean back in the atlas-version wdk strategy.
There was a problem hiding this comment.
I am adding it onto atlas-version.
Azurelol
force-pushed
the
add/preflight_task
branch
from
eeeb199 to
459ffcf
Compare
Larusso
suggested changes
Mar 22, 2022
Comment on lines
131
to
147
| // TODO: Do we need to map this here if the version plugin itself already watches this property (version.scheme)? | ||
| // TODO: Set only the convention to 'wdk' here? | ||
| //def versionScheme = project.properties.getOrDefault("version.scheme", VERSION_SCHEME_DEFAULT) | ||
| // versionExtension.with { | ||
| // switch (versionScheme) { | ||
| // case VERSION_SCHEME_SEMVER_2: | ||
| // versionExtension.versionScheme(VersionScheme.semver2) | ||
| // break | ||
| // case VERSION_SCHEME_SEMVER_1: | ||
| // versionExtension.versionScheme(VersionScheme.semver) | ||
| // break | ||
| // case VERSION_SCHEME_WDK: | ||
| // versionExtension.versionScheme(VersionScheme.wdk) | ||
| // break | ||
| // } | ||
| // } | ||
| versionExtension.versionScheme.convention(VersionScheme.wdk) |
There was a problem hiding this comment.
No I mean adjusting the VERSION_SCHEME_DEFAULT to point to wdk
There was a problem hiding this comment.
Or wait. Scrap this. Leave the old way for now and we deal with this in the WDKs for now.
Azurelol
force-pushed
the
add/preflight_task
branch
from
151401e to
279bf5b
Compare
Azurelol
changed the title
Larusso
approved these changes
Mar 22, 2022
Azurelol
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the preflight release stage.
Changes
preflightrelease stage, as a taskatlas-versionto1.1+, as it includes the newer release stage and wdk strategy.