Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PULLREQUEST_DRONE_PULL_REQUEST drone env #3939

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 19, 2024

#3909 (comment)

cc @wez are you sure its PULLREQUEST_DRONE_PULL_REQUEST and not DRONE_PULL_REQUEST

@6543 6543 added the build_pr_images If set, the CI will build images for this PR and push to Dockerhub label Jul 19, 2024
@wez
Copy link
Contributor

wez commented Jul 19, 2024

@6543 yeah, that env var is definitely the setting I use to get this particular thing to work

@6543
Copy link
Member Author

6543 commented Jul 19, 2024

@wez does the server run on x86 ?

@wez
Copy link
Contributor

wez commented Jul 19, 2024

I run this particular configuration on amd64 and aarch64; so intel and arm, but 64-bit only

@wez
Copy link
Contributor

wez commented Jul 19, 2024

For clarity, I have an amd64 agent and an aarch64 agent. They both build their respective platform packages and docker image, and they both have a step that tries to merge the other architectures together into a multiarch image with plugins/manifest, so I have merge-docker-image-arm and merge-docker-image step as platform-dependent steps in that particular matrix workflow, and they "race" to merge the manifest together. They are set to failure: ignore because one of them will always lose the race.

@6543
Copy link
Member Author

6543 commented Jul 19, 2024

Well in this case the server image woodpeckerci/woodpecker-server:pull_3939 (x84 only) in combination with the newest 2.7.0 agent images should do it

@6543 6543 added the enhancement improve existing features label Jul 19, 2024
@6543 6543 requested a review from a team July 19, 2024 14:00
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.83%. Comparing base (7903d6f) to head (41dc7a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3939      +/-   ##
==========================================
+ Coverage   26.80%   26.83%   +0.02%     
==========================================
  Files         394      394              
  Lines       27496    27507      +11     
==========================================
+ Hits         7370     7381      +11     
  Misses      19425    19425              
  Partials      701      701              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wez
Copy link
Contributor

wez commented Jul 19, 2024

Thanks; I appreciate you doing this, but I'm not sure if I'll be able to try that out today ahead of this being merged as I had to roll back to 2.6 (and reinstall/reconfigure, because there isn't a backwards db migration!) and I had to unblock some other work for today.

@qwerty287 qwerty287 changed the title Add quirk of PULLREQUEST_DRONE_PULL_REQUEST not to be "" Add PULLREQUEST_DRONE_PULL_REQUEST drone env Jul 19, 2024
@qwerty287 qwerty287 merged commit 54b91db into woodpecker-ci:main Jul 19, 2024
9 checks passed
@qwerty287 qwerty287 deleted the droneCompatibilityQuirks branch July 19, 2024 15:15
@woodpecker-bot
Copy link
Collaborator

This was referenced Jul 19, 2024
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build_pr_images If set, the CI will build images for this PR and push to Dockerhub enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants