-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PULLREQUEST_DRONE_PULL_REQUEST drone env #3939
Add PULLREQUEST_DRONE_PULL_REQUEST drone env #3939
Conversation
@6543 yeah, that env var is definitely the setting I use to get this particular thing to work |
@wez does the server run on x86 ? |
I run this particular configuration on amd64 and aarch64; so intel and arm, but 64-bit only |
For clarity, I have an amd64 agent and an aarch64 agent. They both build their respective platform packages and docker image, and they both have a step that tries to merge the other architectures together into a multiarch image with |
Well in this case the server image |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3939 +/- ##
==========================================
+ Coverage 26.80% 26.83% +0.02%
==========================================
Files 394 394
Lines 27496 27507 +11
==========================================
+ Hits 7370 7381 +11
Misses 19425 19425
Partials 701 701 ☔ View full report in Codecov by Sentry. |
Thanks; I appreciate you doing this, but I'm not sure if I'll be able to try that out today ahead of this being merged as I had to roll back to 2.6 (and reinstall/reconfigure, because there isn't a backwards db migration!) and I had to unblock some other work for today. |
Tearing down https://woodpecker-ci-woodpecker-pr-3939.surge.sh |
#3909 (comment)
cc @wez are you sure its
PULLREQUEST_DRONE_PULL_REQUEST
and notDRONE_PULL_REQUEST