-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native forgejo support #3684
Native forgejo support #3684
Conversation
Tested, seems working |
Nice work. Im a bit unsure about the sdk. Is it stable enough to rely on it? Does it anything different from the gitea sdk? As long as forgejo is api compatible we could still use the gitea sdk. |
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3684.surge.sh |
forgejo as to be added to cSpell list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits
Co-authored-by: Robert Kaussow <[email protected]>
It's a fork of the gitea SDK and thus I'd say it's stable. It's not doing that much differently currently except renaming gitea to forgejo. |
Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
So man changes 👀 Maybe worth letting the maintainer know that his fork is now being used by WP? |
He does already: https://codeberg.org/mvdkleijn/forgejo-sdk/issues/2 |
Hiya, maintainer of the forgejo sdk here.. Just wanted to let you know that the SDK is indeed a fork of the Gitea SDK. I made the fork after reading about Forgejo's hardfork since I thought that would make sense. Right now, the fork is the same as the original. I even pulled in the latest updates not too long ago. I plan to add convenience functions next to functions referencing the Forgejo api 1-on-1. In general during the course of 1.x you can expect bug fixes, additions and cleanups. The SDK will use semver so if I make backwards incompatible changes, you can expect a major version bump. I'll probably also add a vanity url for the SDK that people can optionally use so I can move the repo to a different forge if I ever need / want to. My first order of business though is to make a woodpecker pipeline. I already setup WP locally to test the pipeline since I am new to WP. Feel free to leave any feedback over at the repo. (sorry for temporarily hijacking this PR with my comment :-p ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all the work, @qwerty287!
Even though you tested it, maybe we should add a note in the release notes that this is "experimental" for now?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
==========================================
+ Coverage 24.99% 25.85% +0.86%
==========================================
Files 357 361 +4
Lines 25767 26637 +870
==========================================
+ Hits 6441 6888 +447
- Misses 18833 19219 +386
- Partials 493 530 +37 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Robert Kaussow <[email protected]> Co-authored-by: John Olheiser <[email protected]>
I found a third-party fork of the gitea SDK: https://codeberg.org/mvdkleijn/forgejo-sdk
Closes #3637